From: Joe Perches <joe@perches.com>
To: Vivek Natarajan <vivek.natraj@gmail.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/3] ath9k: Add support for AR9287 based chipsets.
Date: Tue, 14 Jul 2009 20:28:32 -0700 [thread overview]
Message-ID: <1247628512.3669.13.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20090715032412.GE4613@myhost>
On Wed, 2009-07-15 at 08:54 +0530, Vivek Natarajan wrote:
> Signed-off-by: Vivek Natarajan <vnatarajan@atheros.com>
> diff --git a/drivers/net/wireless/ath/ath9k/calib.c b/drivers/net/wireless/ath/ath9k/calib.c
> index 1f0c5fe..d1bbb02 100644
> --- a/drivers/net/wireless/ath/ath9k/calib.c
> +++ b/drivers/net/wireless/ath/ath9k/calib.c
> @@ -116,7 +116,7 @@ static void ath9k_hw_do_getnf(struct ath_hw *ah,
> "NF calibrated [ctl] [chain 1] is %d\n", nf);
> nfarray[1] = nf;
>
> - if (!AR_SREV_9280(ah)) {
> + if (!AR_SREV_9280(ah) && !AR_SREV_9287(ah)) {
This looks like it needs a helper function like IS_AR_SREV_928x(ah)
> + if (!AR_SREV_9280(ah) && !AR_SREV_9287(ah)) {
> + else if (AR_SREV_9280(ah) || AR_SREV_9287(ah))
> + if (OLC_FOR_AR9280_20_LATER || OLC_FOR_AR9287_10_LATER)
etc
next prev parent reply other threads:[~2009-07-15 3:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 3:24 [PATCH 3/3] ath9k: Add support for AR9287 based chipsets Vivek Natarajan
2009-07-15 3:28 ` Joe Perches [this message]
2009-07-16 6:53 ` Vivek Natarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1247628512.3669.13.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=vivek.natraj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox