linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	ath9k-devel@lists.ath9k.org
Subject: Re: [PATCH 4/5] mac80211: add WoW support
Date: Wed, 15 Jul 2009 13:57:35 +0200	[thread overview]
Message-ID: <1247659055.2477.0.camel@johannes.local> (raw)
In-Reply-To: <1247617320-20163-5-git-send-email-lrodriguez@atheros.com>

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

On Tue, 2009-07-14 at 20:21 -0400, Luis R. Rodriguez wrote:
> If we're associated and have not already gone into PS mode
> we ensure send a nullfunc frame before going to suspend. Upon
> resume we ensure we restore PS mode if it was enabled and inform
> the driver accordingly, also notify the AP we're awake.
> 
> WoW requires the radio to be left on during suspend, to do this
> we inform drivers of the requested wow triggers on the mac80211
> stop callback.

I don't think this patch would work if ath9k unprogrammed the hardware
correctly in ->remove_interface(), since you don't seem to skip that
call.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  reply	other threads:[~2009-07-15 11:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-15  0:21 [PATCH 0/5] wireless: add wow support Luis R. Rodriguez
2009-07-15  0:21 ` [PATCH 1/5] ath9k: do not stop the queues in driver stop Luis R. Rodriguez
2009-07-15  0:21 ` [PATCH 2/5] adm8211: remove uneeded code during suspend/resume Luis R. Rodriguez
2009-07-15  0:21 ` [PATCH 3/5] cfg80211: add WoW support Luis R. Rodriguez
2009-07-15 11:45   ` Johannes Berg
2009-07-15 15:14     ` Luis R. Rodriguez
2009-07-15 16:05       ` Johannes Berg
2009-07-15 16:16         ` Luis R. Rodriguez
2009-07-15 16:20           ` Johannes Berg
2009-07-15 16:33             ` Luis R. Rodriguez
2009-07-15  0:21 ` [PATCH 4/5] mac80211: " Luis R. Rodriguez
2009-07-15 11:57   ` Johannes Berg [this message]
2009-07-15 15:22     ` Luis R. Rodriguez
2009-07-15 16:03       ` Johannes Berg
2009-07-15 16:18         ` Luis R. Rodriguez
2009-07-15  0:22 ` [PATCH 5/5] ath9k: Add Wake-on-Wireless-LAN support Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1247659055.2477.0.camel@johannes.local \
    --to=johannes@sipsolutions.net \
    --cc=ath9k-devel@lists.ath9k.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=lrodriguez@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).