linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhu Yi <yi.zhu@intel.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v3] cfg80211: rework key operation
Date: Thu, 16 Jul 2009 11:07:07 +0800	[thread overview]
Message-ID: <1247713627.3695.60.camel@debian> (raw)
In-Reply-To: <1247669030.10754.1.camel@johannes.local>

On Wed, 2009-07-15 at 22:43 +0800, Johannes Berg wrote:
> I should also note that you can now get rid of the stuff in iwm that
> caches the keys etc -- key callbacks will only be called after
> connecting.

Thanks. Patches are queued. Will send out later.

> As discussed with Samuel, there's a possibility to pass _all_ WEP keys
> directly to connect(), if desirable, instead of adding them with the
> key hooks later.

I think this should be the right way to go. Currently we have no way to
connect to WEP APs (both open and shared) with iwconfig. Because the
driver needs to set the correct cipher before connect. But the key
callbacks are only called after connected... IWAUTH is expected to be
the place to set the cipher here, but unfortunately iwconfig doesn't use
it. Passing the WEP keys to connect() can solve this issue. The driver
can at least parsing the connect parameters to set the correct cipher
before connect.

Thanks,
-yi


  reply	other threads:[~2009-07-16  3:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-08 11:13 [PATCH] cfg80211: rework key operation Johannes Berg
2009-07-08 11:30 ` [PATCH v2] " Johannes Berg
2009-07-08 12:22   ` [PATCH v3] " Johannes Berg
2009-07-15  8:38     ` Zhu Yi
2009-07-15  9:37       ` Johannes Berg
2009-07-15 14:43         ` Johannes Berg
2009-07-16  3:07           ` Zhu Yi [this message]
2009-07-16  8:41             ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1247713627.3695.60.camel@debian \
    --to=yi.zhu@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).