public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Zhu Yi <yi.zhu@intel.com>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, Zhu Yi <yi.zhu@intel.com>
Subject: [PATCH 09/10] cfg80211: remove WARN_ON in __cfg80211_sme_scan_done
Date: Thu, 16 Jul 2009 17:34:14 +0800	[thread overview]
Message-ID: <1247736854-6760-10-git-send-email-yi.zhu@intel.com> (raw)
In-Reply-To: <1247736854-6760-9-git-send-email-yi.zhu@intel.com>

cfg80211_sme_scan_done() can be called (by fullmac cards) with
wdev->conn == NULL when CFG80211_SME_CONNECTING. We quit silently
instead of WARN_ON in this case.

Signed-off-by: Zhu Yi <yi.zhu@intel.com>
---
 net/wireless/sme.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/wireless/sme.c b/net/wireless/sme.c
index 10ed366..e7a8851 100644
--- a/net/wireless/sme.c
+++ b/net/wireless/sme.c
@@ -227,7 +227,7 @@ static void __cfg80211_sme_scan_done(struct net_device *dev)
 	if (wdev->sme_state != CFG80211_SME_CONNECTING)
 		return;
 
-	if (WARN_ON(!wdev->conn))
+	if (!wdev->conn)
 		return;
 
 	if (wdev->conn->state != CFG80211_CONN_SCANNING &&
-- 
1.6.0.4


  reply	other threads:[~2009-07-16  9:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16  9:34 [PATCH 00/09] iwmc3200wifi updates Zhu Yi
2009-07-16  9:34 ` [PATCH 01/10] iwmc3200wifi: fix UMAC INIT_COMPLETE notification handling Zhu Yi
2009-07-16  9:34   ` [PATCH 02/10] iwmc3200wifi: hardware does not support IP checksum Zhu Yi
2009-07-16  9:34     ` [PATCH 03/10] iwmc3200wifi: set cipher_suites before registering wiphy Zhu Yi
2009-07-16  9:34       ` [PATCH 04/10] iwmc3200wifi: use correct debug level Zhu Yi
2009-07-16  9:34         ` [PATCH 05/10] iwmc3200wifi: cfg80211 managed mode port Zhu Yi
2009-07-16  9:34           ` [PATCH 06/10] iwmc3200wifi: remove setting WEP keys before setting essid support Zhu Yi
2009-07-16  9:34             ` [PATCH 07/10] iwmc3200wifi: make iwm_send_wifi_if_cmd return 0 on success Zhu Yi
2009-07-16  9:34               ` [PATCH 08/10] iwmc3200wifi: remove key caches in driver Zhu Yi
2009-07-16  9:34                 ` Zhu Yi [this message]
2009-07-16  9:39                   ` [PATCH 09/10] cfg80211: remove WARN_ON in __cfg80211_sme_scan_done Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1247736854-6760-10-git-send-email-yi.zhu@intel.com \
    --to=yi.zhu@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox