Re: [PATCH] rfkill: remove too-strict __must_check

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]

On Sat, 2009-07-18 at 19:20 +0100, Alan Jenkins wrote:
> Some drivers don't need the return value of rfkill_set_hw_state(),
> so it should not be marked as __must_check.
> 
> Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>

Acked-by: Johannes Berg <johannes@sipsolutions.net>

Thanks.

> ---
>  include/linux/rfkill.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> index f3d5812..1020290 100644
> --- a/include/linux/rfkill.h
> +++ b/include/linux/rfkill.h
> @@ -238,7 +238,7 @@ void rfkill_destroy(struct rfkill *rfkill);
>   * should be blocked) so that drivers need not keep track of the soft
>   * block state -- which they might not be able to.
>   */
> -bool __must_check rfkill_set_hw_state(struct rfkill *rfkill, bool blocked);
> +bool rfkill_set_hw_state(struct rfkill *rfkill, bool blocked);
>  
>  /**
>   * rfkill_set_sw_state - Set the internal rfkill software block state

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]