From: Johannes Berg <johannes@sipsolutions.net>
To: Zhu Yi <yi.zhu@intel.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] cfg80211: avoid setting default_key if add_key fails
Date: Tue, 21 Jul 2009 12:43:37 +0200 [thread overview]
Message-ID: <1248173017.10870.0.camel@johannes.local> (raw)
In-Reply-To: <1248140853.3747.39.camel@debian>
[-- Attachment #1: Type: text/plain, Size: 584 bytes --]
On Tue, 2009-07-21 at 09:47 +0800, Zhu Yi wrote:
> > Should we even disconnect again in that case?
>
> Yeah, if one key setting is failed, it might not be worth trying others.
Well, even if the others don't fail, the connection wouldn't be working
properly in that case.
> This is true for iwmc3200wifi. But I cannot speak for other drivers. How
> about merge this patch first? This is clearly a bug because the firmware
> confused when it is told to set a key as default but never existed.
Agree, let's merge this first and then see how to disconnect.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2009-07-21 10:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 8:12 [PATCH] cfg80211: avoid setting default_key if add_key fails Zhu Yi
2009-07-20 10:34 ` Johannes Berg
2009-07-21 1:47 ` Zhu Yi
2009-07-21 10:43 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248173017.10870.0.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox