From: Johannes Berg <johannes@sipsolutions.net>
To: ivan.kuten@promwad.com
Cc: linux-wireless@vger.kernel.org,
Yauhen Kharuzhy <yauhen.kharuzhy@promwad.com>
Subject: Re: [PATCH] wireless: Compare ethernet addresses by unaligned safe way
Date: Thu, 23 Jul 2009 19:59:31 +0200 [thread overview]
Message-ID: <1248371971.634.0.camel@johannes.local> (raw)
In-Reply-To: <4A68A465.6020501@promwad.com>
[-- Attachment #1: Type: text/plain, Size: 766 bytes --]
On Thu, 2009-07-23 at 20:56 +0300, Ivan Kuten wrote:
> > On Sun, 2009-06-28 at 15:18 +0300, Ivan Kuten wrote:
> >> Hello,
> >>
> >> In net/wireless/scan.c : cfg80211_wext_siwscan there seems also unaligned allocations
> >> for creq->ssids and creq->channels. Should it be something like that?
> >
> > Seems alright, but there is more than one instance of this, maybe you
> > can make a function to allocate a scan request properly and have it be
> > called from all the places it's needed.
> >
> > johannes
> >
>
> Hello Johannes,
> Can you point to that multiple scan allocations? I see only one kzalloc
> with followed possible alignment violation - it's in cfg80211_wext_siwscan in scan.c
I'm sure there's one in nl80211.c too
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-07-23 18:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 10:54 [PATCH] wireless: Compare ethernet addresses by unaligned safe way Yauhen Kharuzhy
2009-06-16 11:14 ` Johannes Berg
2009-06-28 12:18 ` Ivan Kuten
2009-06-29 7:58 ` Johannes Berg
2009-07-23 17:56 ` Ivan Kuten
2009-07-23 17:59 ` Johannes Berg [this message]
2009-08-07 15:34 ` John W. Linville
2009-06-29 8:23 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248371971.634.0.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=ivan.kuten@promwad.com \
--cc=linux-wireless@vger.kernel.org \
--cc=yauhen.kharuzhy@promwad.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).