From: Marcel Holtmann <marcel@holtmann.org>
To: tim.gardner@canonical.com
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: rfkill blocking is sticky on virtual instances
Date: Thu, 23 Jul 2009 20:11:32 +0200 [thread overview]
Message-ID: <1248372692.28545.127.camel@violet> (raw)
In-Reply-To: <4A68982E.2070101@canonical.com>
Hi Tim,
> > It seems that enabling soft blocking on virtual instances of rfkill is
> > sticky. For example (using 2.6.31-rc4),
> >
> > rtg@lanai:~$ uname -r
> > 2.6.31-4-generic
> > rtg@lanai:~$ rfkill list
> > 0: dell-wifi: Wireless LAN
> > Soft blocked: no
> > Hard blocked: no
> > 1: phy0: Wireless LAN
> > Soft blocked: no
> > Hard blocked: no
> > rtg@lanai:~$ sudo rfkill block all
> > [sudo] password for rtg:
> > rtg@lanai:~$ rfkill list
> > 0: dell-wifi: Wireless LAN
> > Soft blocked: yes
> > Hard blocked: no
> > 1: phy0: Wireless LAN
> > Soft blocked: no
> > Hard blocked: yes
> > rtg@lanai:~$ sudo rfkill unblock all
> > rtg@lanai:~$ rfkill list
> > 0: dell-wifi: Wireless LAN
> > Soft blocked: no
> > Hard blocked: yes
> > 1: phy0: Wireless LAN
> > Soft blocked: no
> > Hard blocked: no
> >
> > Shouldn't I be able to unblock everything at one fell swoop? As long as
> > dell-wifi remains hard blocked, wireless will not reconnect. I've
> > observed this behavior on both iwl3945 as well as iwlagn. Dunno if its
> > driver specific, but I suspect not because I see similar behaviors on
> > platforms with bluetooth.
> >
> > rtg
>
> So, Johannes pointed out that 'all' was not a valid option to
> block/unblock (doh!). Since that is something I think a lot of folks
> would like to be able to do, I've added support for blocking by wireless
> type as well as 'all'.
>
> Please pull:
>
> The following changes since commit 2c3cbb3ae38dd6100ca03d7060b1a0704311d18b:
> Johannes Berg (1):
> bump version to 0.1
>
> are available in the git repository at:
>
> git://kernel.ubuntu.com/rtg/rfkill master
>
> Tim Gardner (3):
> Added a utility function to acquire a list of events.
> Added rfkill_block_all()
> Added support for block/unblock wireless types.
do you mind sending the actual patches. I like to review them.
Regards
Marcel
next prev parent reply other threads:[~2009-07-23 18:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-23 14:58 rfkill blocking is sticky on virtual instances Tim Gardner
2009-07-23 17:04 ` Tim Gardner
2009-07-23 18:11 ` Marcel Holtmann [this message]
2009-07-23 18:13 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248372692.28545.127.camel@violet \
--to=marcel@holtmann.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).