From: Pavel Roskin <proski@gnu.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] mac80211: cooperate more with network namespaces
Date: Mon, 27 Jul 2009 12:40:21 -0400 [thread overview]
Message-ID: <1248712821.11808.6.camel@mj> (raw)
In-Reply-To: <1248711120.6965.6.camel@mj>
On Mon, 2009-07-27 at 12:12 -0400, Pavel Roskin wrote:
> + if (!(info->flags & IEEE80211_TX_INTFL_NEED_TXPROCESSING))
> + continue;
P.S. ieee80211_tx_pending_skb() actually checks
IEEE80211_TX_INTFL_NEED_TXPROCESSING and doesn't use sdata in that case.
Perhaps we could use skb->dev instead of sdata->dev in that case.
Also, the existence of ieee80211_tx_pending_skb() doesn't seem justified
in its present form. It's a piece of ieee80211_tx_pending() that
calculates the same variables and does the checks that the caller should
be doing. I would just integrate it into ieee80211_tx_pending(). If
the result is too complex, we could split it in a more logical way.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-07-27 16:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-13 22:33 [PATCH 0/3] wireless network namespace work Johannes Berg
2009-07-13 22:33 ` [PATCH 1/3] mac80211: cooperate more with network namespaces Johannes Berg
2009-07-27 0:04 ` Pavel Roskin
2009-07-27 8:27 ` Johannes Berg
2009-07-27 15:34 ` Pavel Roskin
2009-07-27 15:59 ` Johannes Berg
2009-07-27 16:02 ` Johannes Berg
2009-07-27 16:12 ` Pavel Roskin
2009-07-27 16:40 ` Pavel Roskin [this message]
2009-07-27 18:22 ` Johannes Berg
2009-07-27 19:02 ` Pavel Roskin
2009-07-27 19:07 ` Johannes Berg
2009-07-27 17:30 ` Johannes Berg
2009-07-13 22:33 ` [PATCH 2/3] cfg80211: make aware of net namespaces Johannes Berg
2009-07-13 22:33 ` [PATCH 3/3] mac80211: allow using network namespaces Johannes Berg
2009-07-13 22:39 ` [HACK] mac80211: don't set netdev parent pointer Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248712821.11808.6.camel@mj \
--to=proski@gnu.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).