public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Igor Perminov <igor.perminov@inbox.ru>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: rt2x00: rt73usb doesn't receive PS Poll frames in the AP mode
Date: Tue, 28 Jul 2009 18:17:58 +0400	[thread overview]
Message-ID: <1248790678.29068.94.camel@sunlight> (raw)
In-Reply-To: <1248787142.8113.10.camel@johannes.local>

> Hmm. Passing up *all* control frames wouldn't really be good -- think of
> all the ACK frames. Do you have filters per frame type?
> 
> Maybe we should introduce a FIF_PSPOLL flag?
> 
> johannes

As I see from the rt2x00 source code, older Ralink devices have common
filter for all control frames. Newer devices (including rt73usb one) can
filter ACK/CTS and other control frames separately. And the rt2800
device has a separate filter for PS Poll frames.

I agree, we should filter out the ACK frames where it is possible.

And in case we introduce the FIF_PSPOLL flag, what the exact semantics
will it have? When the FIF_CONTROL flag is passed to a driver, but the
FIF_PSPOLL one isn't, should the driver filter out PS Poll frames (a) or
not (b)?

May be it would be better to take into account the FIF_PSPOLL flag when
the FIF_CONTROL one isn't passed only (choice b) to be compatible with
the current implementation? I.e. the device should receive PS Poll
frames if either FIF_CONTROL or FIF_PSPOLL is passed (or both of them,
of course).



  reply	other threads:[~2009-07-28 14:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-28 12:36 rt2x00: rt73usb doesn't receive PS Poll frames in the AP mode Igor Perminov
2009-07-28 13:19 ` Johannes Berg
2009-07-28 14:17   ` Igor Perminov [this message]
2009-07-28 15:25     ` Johannes Berg
2009-07-30 20:09       ` Igor Perminov
2009-07-30 20:13         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1248790678.29068.94.camel@sunlight \
    --to=igor.perminov@inbox.ru \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox