From: Dan Williams <dcbw@redhat.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] libertas: Read outside array bounds
Date: Tue, 28 Jul 2009 16:22:54 -0400 [thread overview]
Message-ID: <1248812574.2115.0.camel@localhost.localdomain> (raw)
In-Reply-To: <4A6EAFF3.8050502@gmail.com>
On Tue, 2009-07-28 at 09:59 +0200, Roel Kluin wrote:
> reads bss->rates[j] before checking bounds of index, and should use
> ARRAY_SIZE to determine the size of the array.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Dan Williams <dcbw@redhat.com>
> ---
> diff --git a/drivers/net/wireless/libertas/scan.c b/drivers/net/wireless/libertas/scan.c
> index 601b542..6c95af3 100644
> --- a/drivers/net/wireless/libertas/scan.c
> +++ b/drivers/net/wireless/libertas/scan.c
> @@ -5,6 +5,7 @@
> * for sending scan commands to the firmware.
> */
> #include <linux/types.h>
> +#include <linux/kernel.h>
> #include <linux/etherdevice.h>
> #include <linux/if_arp.h>
> #include <asm/unaligned.h>
> @@ -876,7 +877,7 @@ static inline char *lbs_translate_scan(struct lbs_private *priv,
> iwe.u.bitrate.disabled = 0;
> iwe.u.bitrate.value = 0;
>
> - for (j = 0; bss->rates[j] && (j < sizeof(bss->rates)); j++) {
> + for (j = 0; j < ARRAY_SIZE(bss->rates) && bss->rates[j]; j++) {
> /* Bit rate given in 500 kb/s units */
> iwe.u.bitrate.value = bss->rates[j] * 500000;
> current_val = iwe_stream_add_value(info, start, current_val,
prev parent reply other threads:[~2009-07-28 20:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-28 7:59 [PATCH] libertas: Read outside array bounds Roel Kluin
2009-07-28 8:13 ` Holger Schurig
2009-07-28 20:22 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248812574.2115.0.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox