From: Igor Perminov <igor.perminov@inbox.ru>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH] mac80211: FIF_PSPOLL filter flag
Date: Thu, 30 Jul 2009 19:05:36 +0400 [thread overview]
Message-ID: <1248966336.29068.178.camel@sunlight> (raw)
In-Reply-To: <1248963525.16129.2.camel@johannes.local>
> > @@ -497,6 +509,13 @@ static int ieee80211_stop(struct net_device *dev)
> > }
> > /* fall through */
> > default:
> > + if (sdata->vif.type == NL80211_IFTYPE_AP) {
>
> I'd probably put this after a
> case NL80211_IFTYPE_AP:
> label but you need the if () anyway ... hmm I guess we really should
> clean up this code and split it into two switch statements...
And may be do it above?
if (sdata->flags & IEEE80211_SDATA_ALLMULTI)
atomic_dec(&local->iff_allmultis);
if (sdata->flags & IEEE80211_SDATA_PROMISC)
atomic_dec(&local->iff_promiscs);
+ if (sdata->vif.type == NL80211_IFTYPE_AP)
+ local->fif_pspoll--;
+
netif_addr_lock_bh(dev);
spin_lock_bh(&local->filter_lock);
__dev_addr_unsync(&local->mc_list, &local->mc_count,
&dev->mc_list, &dev->mc_count);
ieee80211_configure_filter(local);
spin_unlock_bh(&local->filter_lock);
netif_addr_unlock_bh(dev);
Igor
next prev parent reply other threads:[~2009-07-30 15:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-30 13:53 [RFC PATCH] mac80211: FIF_PSPOLL filter flag Igor Perminov
2009-07-30 14:18 ` Johannes Berg
2009-07-30 15:05 ` Igor Perminov [this message]
2009-07-30 15:31 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1248966336.29068.178.camel@sunlight \
--to=igor.perminov@inbox.ru \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox