Re: [PATCH v2 1/3] cfg80211: use goto out on 11d reg hint failure

Johannes Berg
2009-07-30T17:28:22Z

[-- Attachment #1: Type: text/plain, Size: 815 bytes --]

On Thu, 2009-07-30 at 10:19 -0700, Luis R. Rodriguez wrote:
> This does not change functionality.
>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>

Acked-by: Johannes Berg <johannes@sipsolutions.net>

> ---
> net/wireless/reg.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/net/wireless/reg.c b/net/wireless/reg.c
> index fb40428..2d1d183 100644
> --- a/net/wireless/reg.c
> +++ b/net/wireless/reg.c
> @@ -1774,10 +1774,8 @@ void regulatory_hint_11d(struct wiphy *wiphy,
>
> mutex_lock(&cfg80211_mutex);
>
> - if (unlikely(!last_request)) {
> - mutex_unlock(&cfg80211_mutex);
> - return;
> - }
> + if (unlikely(!last_request))
> + goto out;
>
> /* IE len must be evenly divisible by 2 */
> if (country_ie_len & 0x01)

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]