Re: [PATCH] cfg80211: fix regression on beacon world roaming feature

Luis R. Rodriguez
2009-07-31T16:03:53Z

On Fri, Jul 31, 2009 at 8:56 AM, Johannes Berg<johannes@sipsolutions.net> wrote:
> On Fri, 2009-07-31 at 08:49 -0700, Luis R. Rodriguez wrote:
>
>> > just set the _flags_ in their reg
>> > notifier,
>>
>> So if you mean devices that used custom reg stuff, the answer is no
>> because the patch which introduced the regression would prevent the
>> setting of the passive scan flag and beaconing restrictions so the
>> reg_notifier would never notice the difference.
>
> I did mean those devices. Adding a reg notifier hook for iwlwifi seems a
> little odd, given that cfg80211 is supposed to always honour the flags
> (which it copies to orig_flags for that purpose).
>
> But I don't see why ath couldn't do this:
>
>  * do _not_ set the passive/no-ibss flags in flags (orig_flags)

That's up to cfg80211 through the custom regdomain, so yes, and in
fact we can WARN if these are set.

>  * in the reg notifier, always set the passive/no-ibss flag into 'flags'
>   unless a beacon was noticed on that channel.

That's fine too, we still need a fix for 2.6.31. Do you have any
thoughts on that?

Luis