Re: [PATCH] cfg80211: fix regression on beacon world roaming feature

Johannes Berg
2009-07-31T15:56:27Z

[-- Attachment #1: Type: text/plain, Size: 852 bytes --]

On Fri, 2009-07-31 at 08:49 -0700, Luis R. Rodriguez wrote:

> > just set the _flags_ in their reg
> > notifier,
>
> So if you mean devices that used custom reg stuff, the answer is no
> because the patch which introduced the regression would prevent the
> setting of the passive scan flag and beaconing restrictions so the
> reg_notifier would never notice the difference.

I did mean those devices. Adding a reg notifier hook for iwlwifi seems a
little odd, given that cfg80211 is supposed to always honour the flags
(which it copies to orig_flags for that purpose).

But I don't see why ath couldn't do this:

* do _not_ set the passive/no-ibss flags in flags (orig_flags)
* in the reg notifier, always set the passive/no-ibss flag into 'flags'
unless a beacon was noticed on that channel.

What am I missing?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]