linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org, Patrick McHardy <kaber@trash.net>
Subject: Re: wpa_test not used in wpa.c
Date: Sat, 01 Aug 2009 09:11:42 +0200	[thread overview]
Message-ID: <1249110702.26584.7.camel@johannes.local> (raw)
In-Reply-To: <4A73655D.1020205@candelatech.com>

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

On Fri, 2009-07-31 at 14:42 -0700, Ben Greear wrote:
> It seems to me that in this method (and others), wpa_test is not
> actually assigned a useful value, but it's still tested in code
> branches.

> 
> Any idea on how this is supposed to work?

It isn't really. It's some dead code that you can enable manually for
testing or so. It used to be possible to use a private ioctl or so to
set it, iirc, but that's long gone. I'd have no objections to just
removing it.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  reply	other threads:[~2009-08-01  7:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-31 21:42 wpa_test not used in wpa.c Ben Greear
2009-08-01  7:11 ` Johannes Berg [this message]
2009-08-01 15:54   ` Gábor Stefanik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249110702.26584.7.camel@johannes.local \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=kaber@trash.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).