Re: [PATCH 4/5] mwl8k: prevent crash in ->configure_filter() if no interface was added

Johannes Berg
2009-08-04T06:38:03Z

[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]

On Tue, 2009-08-04 at 01:46 +0200, Lennert Buytenhek wrote:
> On Mon, Aug 03, 2009 at 10:03:10PM +0200, Johannes Berg wrote:
>
> > > if (changed_flags & FIF_BCN_PRBRESP_PROMISC) {
> > > if (*total_flags & FIF_BCN_PRBRESP_PROMISC)
> > > rc = mwl8k_cmd_set_pre_scan(hw);
> > > else {
> > > - mv_vif = MWL8K_VIF(priv->vif);
> > > - rc = mwl8k_cmd_set_post_scan(hw, mv_vif->bssid);
> >
> > Btw, there are pre- and post-scan hooks now.
>
> These hardware commands are slightly misnamed -- they are called
> PRE_SCAN/POST_SCAN, but what they do is program the receive filter.
> It seems appropriate to keep that in ->configure_filter() ?

I guess it depends how they configure the filter. :)
If they really do the beacon/probe response filter thing then yes. For
b43, for instance, they also disable CFP updates etc. so aren't just
that. And you can get FIF_BCN_PRBRESP_PROMISC even while _not_ scanning,
due to monitor interfaces, so it really depends what they do (no CFP
disabling wanted then).

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]