Re: [PATCH 4/5] mwl8k: prevent crash in ->configure_filter() if no interface was added

Lennert Buytenhek
2009-08-03T23:46:51Z

On Mon, Aug 03, 2009 at 10:03:10PM +0200, Johannes Berg wrote:

> > if (changed_flags & FIF_BCN_PRBRESP_PROMISC) {
> > if (*total_flags & FIF_BCN_PRBRESP_PROMISC)
> > rc = mwl8k_cmd_set_pre_scan(hw);
> > else {
> > - mv_vif = MWL8K_VIF(priv->vif);
> > - rc = mwl8k_cmd_set_post_scan(hw, mv_vif->bssid);
>
> Btw, there are pre- and post-scan hooks now.

These hardware commands are slightly misnamed -- they are called
PRE_SCAN/POST_SCAN, but what they do is program the receive filter.
It seems appropriate to keep that in ->configure_filter() ?