linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: mac80211 TX frame alignment
Date: Tue, 04 Aug 2009 19:37:16 +0200	[thread overview]
Message-ID: <1249407436.24787.6.camel@johannes.local> (raw)
In-Reply-To: <200908041905.11632.IvDoorn@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

Hi Ivo,

> Do you know if for outgoing frames the header should always
> be 4-byte aligned?

I know that there's no alignment guarantee.

> I have a bugreport from users claiming that master mode
> is failing for rt2500pci because the beacons passed to the
> driver are not 4-byte aligned which causes the device not
> to send out the beacons correctly.
> 
> I'm just wondering if this is something that should be fixed
> in the driver or in mac80211.

I don't think we can fix that in mac80211, since we don't know whether
or not any alignment is required. We could align beacon frames, I
suppose, since those are created on the fly, but not data frames.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  reply	other threads:[~2009-08-04 17:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-04 17:05 mac80211 TX frame alignment Ivo van Doorn
2009-08-04 17:37 ` Johannes Berg [this message]
2009-08-05 18:57   ` Ivo van Doorn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1249407436.24787.6.camel@johannes.local \
    --to=johannes@sipsolutions.net \
    --cc=ivdoorn@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).