From: Johannes Berg <johannes@sipsolutions.net>
To: Javier Cardona <javier@cozybit.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
xxiao <austinxxh-ath9k@yahoo.com>,
linux-wireless@vger.kernel.org
Subject: Re: Status of 802.11s in wireless-testing?
Date: Wed, 05 Aug 2009 20:23:56 +0200 [thread overview]
Message-ID: <1249496636.6902.29.camel@johannes.local> (raw)
In-Reply-To: <445f43ac0908051049wb32ea49r3e8894fd99f4ae60@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1504 bytes --]
Hi Javier,
> I agree that there is a bug in that would cause a synchronize_rcu() in
> an atomic section when the mpath table grows beyond a certain size.
> The bug was there since the first submission of the mesh code, yes.
>
> However, the "bunch of bugs that appear to have been in the code
> forever" are, I believe, regressions. In particular we've identified:
> - Airtime Link Metric broken (fix in progress)
> - Forwarding path broken (fixed here:
> http://marc.info/?l=linux-wireless&m=124698982910794&w=2)
> - mpath pending queue broken (fixed here:
> http://marc.info/?l=linux-wireless&m=124717648406661&w=2)
> - PREQ notification broken (fixed here:
> http://marc.info/?l=linux-wireless&m=124752948320455&w=2)
>
> We've been busy with those but the synchronize_rcu fix is next in our list.
I was really only referring to the issue with synchronize_rcu(), and the
two related things where there's GFP_KERNEL that should be GFP_ATOMIC,
although that might have been fixed? It just felt like multiple
issues/places to me that could run into this.
> I also agree with your assessment of the severity of the bug.
> Hopefully we'll get to fix it really soon so we can re-enable mesh
> again.
Yes, that would be great, thanks. I've been meaning to look into this
(if only to understand the mesh code better), but I have little time and
a lot of other things to fix that are still regressions (currently
looking at assoc vs. reassoc for instance).
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2009-08-05 18:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2f1373ed0908042145pc83adc5qd968e3bf8d0ce3c7@mail.gmail.com>
2009-08-05 16:08 ` Status of 802.11s in wireless-testing? xxiao
2009-08-05 16:50 ` John W. Linville
2009-08-05 17:04 ` Johannes Berg
2009-08-05 17:49 ` Javier Cardona
2009-08-05 18:23 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1249496636.6902.29.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=austinxxh-ath9k@yahoo.com \
--cc=javier@cozybit.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox