From: Javier Cardona <javier@cozybit.com>
To: linux-wireless@vger.kernel.org
Cc: andrey@cozybit.com, johannes@sipsolutions.net,
linville@tuxdriver.com, devel@lists.open80211s.org,
xinhua_wu@realsil.com.cn
Subject: Fix preq frame process and peer link frame baselen.
Date: Wed, 12 Aug 2009 11:03:42 -0700 [thread overview]
Message-ID: <1250100224-23832-1-git-send-email-javier@cozybit.com> (raw)
In-Reply-To: <4A82639F.6000908@realsil.com.cn>
> Yes, I agree with you, and this patch is just to check whether this PREQ is valid with
> the ttl it contains instead of local TTL, and the local TTL has also been provided for
> PREP further process.
I'm still unconvinced with that change. The ttl check you refer to is done on
transmission: PREQs with ttl of zero are never transmitted. See further down in
that same function:
ttl = PREQ_IE_TTL(preq_elem);
lifetime = PREQ_IE_LIFETIME(preq_elem);
if (ttl <= 1) {
/* supress frame */
Furthermore, with the change you propose, you open the possibility for PREPs to
be transmitted with ttl=0 (if ifmsh->mshcfg.dot11MeshTTL was set to zero).
Regarding your baselen explanation, I now understand it and agree to the
suggested change. Your initial patch submission was reversed and I got confused
looking at two version of the same.
I've created a new series with the parts of your patch that I agree with. They
follow this e-mail.
Thanks!
Javier
next prev parent reply other threads:[~2009-08-12 18:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-11 10:22 diff --git a/net/mac80211/mesh_hwmp.c b/net/mac80211/mesh_hwmp.c David Woo
2009-08-11 10:50 ` Johannes Berg
2009-08-11 11:47 ` david woo
2009-08-11 18:47 ` John W. Linville
2009-08-12 0:33 ` 吴新华
2009-08-12 1:42 ` Javier Cardona
2009-08-12 6:39 ` david woo
2009-08-12 18:03 ` Javier Cardona [this message]
2009-08-12 18:03 ` [PATCH 1/2] mac80211: Mark a destination sequence number as valid when a PREQ is received Javier Cardona
2009-08-12 18:03 ` [PATCH 2/2] mac80211: Fix invalid length passed to IE parser for PLINK CONFIRM frames Javier Cardona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250100224-23832-1-git-send-email-javier@cozybit.com \
--to=javier@cozybit.com \
--cc=andrey@cozybit.com \
--cc=devel@lists.open80211s.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=xinhua_wu@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).