Linux wireless drivers development
 help / color / mirror / Atom feed
From: Mario Limonciello <Mario_Limonciello@Dell.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-wireless@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Mario Limonciello <Mario_Limonciello@Dell.com>
Subject: [PATCH] When the "hardware" switch is disabled, don't actually allow changing the softblock status.
Date: Wed, 19 Aug 2009 18:34:01 -0500	[thread overview]
Message-ID: <1250724841-12527-1-git-send-email-Mario_Limonciello@Dell.com> (raw)

The "hardware" switch is tied directly to a BIOS interface that will connect and 
disconnect the hardware from the bus.

If you use the software interface to request the BIOS to make these changes, the HW
switch will be in an inconsistent state and LEDs may not reflect the state of the HW.

Signed-off-by: Mario Limonciello <Mario_Limonciello@Dell.com>
---
 drivers/platform/x86/dell-laptop.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index 90a3d7c..2469ad5 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -180,6 +180,10 @@ static int dell_rfkill_set(int radio, enum rfkill_state state)
 	int disable = (state == RFKILL_STATE_UNBLOCKED) ? 0 : 1;
 
 	memset(&buffer, 0, sizeof(struct calling_interface_buffer));
+	dell_send_request(&buffer, 17, 11);
+	if (!(buffer.output[1] & BIT(16)))
+		return -EINVAL;
+
 	buffer.input[0] = (1 | (radio<<8) | (disable << 16));
 	dell_send_request(&buffer, 17, 11);
 
-- 
1.6.3.3


                 reply	other threads:[~2009-08-19 23:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1250724841-12527-1-git-send-email-Mario_Limonciello@Dell.com \
    --to=mario_limonciello@dell.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox