From: reinette chatre <reinette.chatre@intel.com>
To: "Gábor Stefanik" <netrolller.3d@gmail.com>
Cc: John Linville <linville@tuxdriver.com>,
"Zhu, Yi" <yi.zhu@intel.com>,
"Guy, Wey-Yi W" <wey-yi.w.guy@intel.com>,
Rafael Laufer <rlaufer@cs.ucla.edu>,
ipw3945-devel <ipw3945-devel@lists.sourceforge.net>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] iwlwifi: Make injection of non-broadcast frames work again
Date: Fri, 21 Aug 2009 13:49:27 -0700 [thread overview]
Message-ID: <1250887767.30019.14483.camel@rc-desk> (raw)
In-Reply-To: <4A8EEAF9.6020308@gmail.com>
On Fri, 2009-08-21 at 11:44 -0700, Gábor Stefanik wrote:
> Commit 1ccb84d87d04df3c76cd4352fe69786d8c7cf016 by Wey-Yi Guy
> ("iwlwifi: clean up unused NL80211_IFTYPE_MONITOR for Monitor mode")
> broke injection of non-broadcast frames to unassociated stations
> (causing a SYSASSERT for all such injected frames), due to injected
> frames no longer automatically getting a broadcast station ID assigned.
> This patch restores the old behavior, fixing the aforementioned
> regression.
>
> Also, consistently check for IEEE80211_TX_CTL_INJECTED instead of
> iwl_is_monitor_mode in the TX path, as TX_CTL_INJECTED specifically
> means that a given packet is coming from a monitor interface, while
> iwl_is_monitor_mode only shows whether a monitor interface exists
> on the device.
>
> Signed-off-by: Gábor Stefanik <netrolller.3d@gmail.com>
Acked-by: Reinette Chatre <reinette.chatre@intel.com>
Thank you
Reinette
prev parent reply other threads:[~2009-08-21 20:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-21 18:44 [PATCH v2] iwlwifi: Make injection of non-broadcast frames work again Gábor Stefanik
2009-08-21 20:49 ` reinette chatre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250887767.30019.14483.camel@rc-desk \
--to=reinette.chatre@intel.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netrolller.3d@gmail.com \
--cc=rlaufer@cs.ucla.edu \
--cc=wey-yi.w.guy@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox