Re: [PATCH] mac80211 : fix a race with update_tkip_key

Johannes Berg
2009-06-11T20:10:39Z

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]

On Thu, 2009-06-11 at 00:17 +0200, gregor kowski wrote:

> >> Might depend on something else? Anyhow I don't see the point of
> >> continuing to call the callback. Maybe it should just be part of the key
> >> todo instead when the key is initially uploaded to the hw.
> >
> > Or what do you think about this. This will call the callback only once per wrap.

> But this won't work if you want to support QOS.
> So how update_tkip_key is supposed to work with QOS (ie different
> rx->queue value) and multiple tkip IV ?
>
> BTW did you know why there only one tkip IV on tx and not one per qos queue ?

Umm, have you read the standard? This is correct behaviour and works as
specified with QoS.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]