Re: [PATCH] mac80211 : fix a race with update_tkip_key

Johannes Berg
2009-11-07T19:22:34Z

[-- Attachment #1: Type: text/plain, Size: 597 bytes --]

On Sat, 2009-11-07 at 19:10 +0100, gregor kowski wrote:

> >> +enum ieee80211_internal_tkip_initialized {
> >> + TKIP_INITIALIZED_NONE,
> >> + TKIP_INITIALIZED_PHASE1,
> >> + TKIP_INITIALIZED_UPDATE_KEY,
> >> +};
> >
> > Those constants and the enum itself really need better names. This way,
> > there's no way to understand what it means without reading all the code.
> >
> Could you suggest better name ?
>
> ieee80211_internal_tkip_state and
> TKIP_STATE_NOT_INIT
> TKIP_STATE_PHASE1_DONE
> TKIP_STATE_PHASE1_HW_UPLOADED

I, eh, ... have no idea :)

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]