From: Pavel Roskin <proski@gnu.org>
To: Bob Copeland <me@bobcopeland.com>
Cc: linville@tuxdriver.com, jirislaby@gmail.com, mickflemm@gmail.com,
lrodriguez@atheros.com, linux-wireless@vger.kernel.org,
ath5k-devel@lists.ath5k.org
Subject: Re: [PATCH 4/4] ath5k: add hardware CCMP encyption support
Date: Wed, 26 Aug 2009 22:09:31 -0400 [thread overview]
Message-ID: <1251338971.17295.17.camel@mj> (raw)
In-Reply-To: <1251169233-24169-5-git-send-email-me@bobcopeland.com>
On Mon, 2009-08-24 at 23:00 -0400, Bob Copeland wrote:
> + ah->ah_aes_support =
> + (ee->ee_version >= AR5K_EEPROM_VERSION_5_0 &&
> + !AR5K_EEPROM_AES_DIS(ee->ee_misc5) &&
> + (ah->ah_mac_version > (AR5K_SREV_AR5212 >> 4) ||
> + (ah->ah_mac_version == (AR5K_SREV_AR5212 >> 4) &&
> + ah->ah_mac_revision >= (AR5K_SREV_AR5211 >> 4))));
The above use of ah->ah_mac_revision is clearly incorrect. You are
comparing a revision with a symbol for a version.
I suggest that you use ah_mac_srev instead. Before this patch,
ah_mac_revision was a write-only variable and was a good candidate for
removal.
The last three quoted lines are equivalent to (ah->ah_mac_srev >= 0x54)
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-08-27 2:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-25 3:00 [PATCH 0/4] ath5k: misc updates Bob Copeland
2009-08-25 3:00 ` [PATCH 1/4] ath5k: clean up filter flags setting Bob Copeland
2009-08-25 3:00 ` [PATCH 2/4] ath5k: add led pin configuration for compaq c700 laptop Bob Copeland
2009-08-25 3:00 ` [PATCH 3/4] ath5k: use the skb->cb directly for RX status Bob Copeland
2009-08-25 3:00 ` [PATCH 4/4] ath5k: add hardware CCMP encyption support Bob Copeland
2009-08-27 2:09 ` Pavel Roskin [this message]
2009-08-27 3:27 ` Bob Copeland
2009-08-27 19:17 ` Bob Copeland
2009-09-01 22:03 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251338971.17295.17.camel@mj \
--to=proski@gnu.org \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).