[PATCH] rndis_wlan: increase scan timer delay

[PATCH] rndis_wlan: increase scan timer delay

[Jussi Kivilinna]

Increase scan delay from 1 sec to 6 sec. Spec says that scan by
OID_802_11_BSSID_LIST_SCAN completes in 6 seconds.
Before rfkill patch too short delay was not problem as device was
always active (radio on) and performing background scanning.

Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
---

 drivers/net/wireless/rndis_wlan.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c
index f181b00..6d49e80 100644
--- a/drivers/net/wireless/rndis_wlan.c
+++ b/drivers/net/wireless/rndis_wlan.c
@@ -1599,7 +1599,7 @@ static int rndis_get_tx_power(struct wiphy *wiphy, int *dbm)
 }
 
 
-#define SCAN_DELAY_JIFFIES (HZ)
+#define SCAN_DELAY_JIFFIES (HZ * 6)
 static int rndis_scan(struct wiphy *wiphy, struct net_device *dev,
 			struct cfg80211_scan_request *request)
 {

Re: [PATCH] rndis_wlan: increase scan timer delay

[Jussi Kivilinna]

Please, don't merge this after all. Blocks scan too long and breaks  
NetworkManager/wpa_supplicant.

Quoting "Jussi Kivilinna" <jussi.kivilinna@mbnet.fi>:

> Increase scan delay from 1 sec to 6 sec. Spec says that scan by
> OID_802_11_BSSID_LIST_SCAN completes in 6 seconds.
> Before rfkill patch too short delay was not problem as device was
> always active (radio on) and performing background scanning.
>
> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>

Re: [PATCH] rndis_wlan: increase scan timer delay

[Dan Williams]

On Thu, 2009-08-27 at 13:43 +0300, Jussi Kivilinna wrote:
> Please, don't merge this after all. Blocks scan too long and breaks  
> NetworkManager/wpa_supplicant.

Hmm, it shouldn't.  I've seen other cards (ath5k a/b/g) take 5 to 8
seconds to scan when they scan all the bands.  iwlwifi sometimes takes 5
seconds to scan as well.  That should all be valid.

Can you get some wpa_supplicant runs with "-dddt" that show the problem
you're having?  NM uses the supplicant for all scanning activity.  It
shouldn't really "break" NM, so if it does I'd like to fix that.

Dan

Re: [PATCH] rndis_wlan: increase scan timer delay

[Jussi Kivilinna]

Quoting "Dan Williams" <dcbw@redhat.com>:

> On Thu, 2009-08-27 at 13:43 +0300, Jussi Kivilinna wrote:
>> Please, don't merge this after all. Blocks scan too long and breaks
>> NetworkManager/wpa_supplicant.
>
> Hmm, it shouldn't.  I've seen other cards (ath5k a/b/g) take 5 to 8
> seconds to scan when they scan all the bands.  iwlwifi sometimes takes 5
> seconds to scan as well.  That should all be valid.
>

You're right, increasing delay exposed bug that caused reconnects.  
With short delay (re)scans didn't block so long and connection was  
established faster. With 6 sec connection was established eventually.

I'll send bug fix (workaround really, hw sometimes sends extra media  
connect events when setting WPA keys, which needs to be ignored) and  
resend this patch in two patch set after more testing.

-Jussi