From: reinette chatre <reinette.chatre@intel.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: "Zhu, Yi" <yi.zhu@intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] iwlagn: show_version() displays confusing/wrong firmware version
Date: Thu, 27 Aug 2009 07:57:21 -0700 [thread overview]
Message-ID: <1251385041.3805.17.camel@rc-desk> (raw)
In-Reply-To: <1251379989-20728-1-git-send-email-bjorn@mork.no>
Hi Bjørn,
Which kernel/repo is your patch based on?
On Thu, 2009-08-27 at 06:33 -0700, Bjørn Mork wrote:
> The output of show_version() is confusing at best, and can also be
> considered wrong
Correct. Since this information is already printed in the system logs we
determined that the version sysfs file is not needed and has been
removed. Your patch is thus not relevant to the recent code
(wireless-testing repository).
Here is the patch for your reference:
commit 44f313c2e63dcf93b17e6a43769105e487e2e49d
Author: Jay Sternberg <jay.e.sternberg@intel.com>
Date: Fri Jul 31 14:28:09 2009 -0700
iwlwifi: remove duplicated version info from sysfs
version info in sysfs had been determined to be unnecessary as it
is already provided in syslog info. nvm version is added to syslog
version info as a debug level message to provide all info that was
in the version sysfs data.
Signed-off-by: Jay Sternberg <jay.e.sternberg@intel.com>
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Reinette
next prev parent reply other threads:[~2009-08-27 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-27 13:33 [PATCH] iwlagn: show_version() displays confusing/wrong firmware version Bjørn Mork
2009-08-27 14:57 ` reinette chatre [this message]
2009-08-27 15:09 ` Bjørn Mork
2009-08-27 15:29 ` reinette chatre
2009-08-27 16:50 ` Bjørn Mork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251385041.3805.17.camel@rc-desk \
--to=reinette.chatre@intel.com \
--cc=bjorn@mork.no \
--cc=linux-wireless@vger.kernel.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox