From: Pavel Roskin <proski@gnu.org>
To: Sujith <Sujith.Manoharan@atheros.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] ath9k: Fix channelFlags for 2GHZ
Date: Thu, 03 Sep 2009 11:19:47 -0400 [thread overview]
Message-ID: <1251991187.6521.22.camel@mj> (raw)
In-Reply-To: <19103.25725.707217.596352@gargle.gargle.HOWL>
On Thu, 2009-09-03 at 12:08 +0530, Sujith wrote:
> CHANNEL_G has to be set for 2GHZ channels since
> IS_CHAN_G() checks for this in channelFlags and not in
> chanmode. To make things messier, ath9k_hw_process_ini()
> checks for CHANNEL_G in chanmode and not in channelFlags.
> The supreme, brain-searing fix is to set the
> flag in both cases.
My impression is that's a workaround for a bug that lies elsewhere. I
don't think we should apply such patches.
chanmode and channelFlags seem to duplicate each other. I would use an
enum for distinctive allowed modes and macros to query if the particular
mode has a specific feature (band, modulation, bandwidth etc).
The enum could use ORed constants for optimization, but such constants
should be used only through the macros.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2009-09-03 15:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 6:38 [PATCH 2/2] ath9k: Fix channelFlags for 2GHZ Sujith
2009-09-03 15:19 ` Pavel Roskin [this message]
2009-09-03 18:28 ` Luis R. Rodriguez
2009-09-04 3:27 ` Sujith
2009-09-04 3:25 ` Sujith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251991187.6521.22.camel@mj \
--to=proski@gnu.org \
--cc=Sujith.Manoharan@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).