From: reinette chatre <reinette.chatre@intel.com>
To: Frans Pop <elendil@planet.nl>
Cc: Mel Gorman <mel@csn.ul.ie>,
Larry Finger <Larry.Finger@lwfinger.net>,
"John W. Linville" <linville@tuxdriver.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ipw3945-devel@lists.sourceforge.net"
<ipw3945-devel@lists.sourceforge.net>,
Andrew Morton <akpm@linux-foundation.org>,
"cl@linux-foundation.org" <cl@linux-foundation.org>,
"Krauss, Assaf" <assaf.krauss@intel.com>,
Johannes Berg <johannes@sipsolutions.net>,
"Abbas, Mohamed" <mohamed.abbas@intel.com>
Subject: Re: iwlagn: order 2 page allocation failures
Date: Thu, 10 Sep 2009 11:50:24 -0700 [thread overview]
Message-ID: <1252608624.30150.312.camel@rc-desk> (raw)
In-Reply-To: <200909102043.17883.elendil@planet.nl>
On Thu, 2009-09-10 at 11:43 -0700, Frans Pop wrote:
> Looks good to me (from a user's perspective).
Thank you very much for looking at it.
> IIUC the first message is now only displayed if IWL debugging is
> explicitly enabled,
Correct. User will have to enable debug flag of 0x1.
> It seems to me that, with debugging enabled, the "Failed to allocate SKB
> buffer." message may get repeated, but I guess that's minor.
Yes, it will be repeated. I did add a "net_ratelimit()" to it so it
should not be too overwhelming. I did not care to limit it even more
since we are now talking about a debug message as opposed to an error
message on the console.
> One nitpick. As you've made the message into sentences, "Only %u free
> buffers remaining" should IMO also end with a period.
Sorry - will fix. I will not post a new version to this thread for this
issue, but it will be fixed in the next version I send out.
Reinette
next prev parent reply other threads:[~2009-09-10 18:50 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-06 7:40 iwlagn: order 2 page allocation failures Frans Pop
2009-09-06 8:14 ` Pekka Enberg
2009-09-06 8:28 ` Frans Pop
2009-09-06 8:35 ` Pekka Enberg
2009-09-08 10:54 ` Mel Gorman
2009-09-08 11:11 ` Pekka Enberg
2009-09-08 14:17 ` John W. Linville
2009-09-08 14:59 ` Larry Finger
2009-09-09 15:04 ` Mel Gorman
2009-09-09 15:59 ` Frans Pop
2009-09-09 16:55 ` Mel Gorman
2009-09-09 17:19 ` Frans Pop
2009-09-16 14:36 ` Frans Pop
2009-09-16 15:02 ` Mel Gorman
2009-09-16 15:37 ` Frans Pop
2009-09-16 16:26 ` reinette chatre
2009-09-09 20:05 ` reinette chatre
2009-09-10 1:48 ` Frans Pop
2009-09-10 9:02 ` Mel Gorman
2009-09-10 18:15 ` reinette chatre
2009-09-10 18:43 ` Frans Pop
2009-09-10 18:50 ` reinette chatre [this message]
2009-09-11 8:45 ` Mel Gorman
2009-09-11 16:14 ` reinette chatre
2009-09-10 21:14 ` reinette chatre
2009-09-11 8:47 ` Mel Gorman
2009-09-14 3:01 ` Zhu Yi
2009-09-14 13:06 ` Mel Gorman
2009-09-15 8:30 ` alloc skb based on a given data buffer Zhu Yi
2009-09-15 8:33 ` David Miller
2009-09-15 8:57 ` Zhu Yi
2009-09-15 9:09 ` David Miller
2009-09-15 9:15 ` Zhu Yi
2009-09-15 15:30 ` Johannes Berg
2009-09-15 21:16 ` David Miller
2009-09-19 5:56 ` Johannes Berg
2009-09-14 15:42 ` iwlagn: order 2 page allocation failures Christoph Lameter
2009-09-14 17:59 ` Mel Gorman
2009-09-14 18:04 ` Christoph Lameter
2009-09-10 8:18 ` Pekka Enberg
2009-09-10 12:34 ` Mel Gorman
2009-09-10 12:39 ` Pekka Enberg
2009-09-10 12:58 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252608624.30150.312.camel@rc-desk \
--to=reinette.chatre@intel.com \
--cc=Larry.Finger@lwfinger.net \
--cc=akpm@linux-foundation.org \
--cc=assaf.krauss@intel.com \
--cc=cl@linux-foundation.org \
--cc=elendil@planet.nl \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mel@csn.ul.ie \
--cc=mohamed.abbas@intel.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).