Re: [PATCH 07/13] iwlwifi: clean up ht config a little

Johannes Berg
2009-09-12T13:12:25Z

[-- Attachment #1: Type: text/plain, Size: 723 bytes --]

On Fri, 2009-09-11 at 19:46 +0200, Gábor Stefanik wrote:
> On Fri, Sep 11, 2009 at 7:38 PM, Reinette Chatre
> <reinette.chatre@intel.com> wrote:
> > From: Johannes Berg <johannes@sipsolutions.net>
> >
> > is_ht can be bool instead of u8, and there's
> > no need to use IWL_CHANNEL_WIDTH_* constants
> > in supported_chan_width when that could just
> > be named is_40mhz instead.
>
> What about is_ht40?

Wrong approach. If you want to clean it up further, I would suggest
replacing both "is_ht" and "is_40mhz" by the channel type as passed by
mac80211, or using conf_is_ht40() etc. instead. Didn't feel motivated
enough at this point though and just wanted to get rid of the extra
constants.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]