From: Johannes Berg <johannes@sipsolutions.net>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
John W Linville <linville@tuxdriver.com>
Subject: Re: [PATCH] cfg80211: don't report SME connection errs at SIOCSIW{FREQ/AP/ESSID}
Date: Mon, 14 Sep 2009 10:43:54 -0700 [thread overview]
Message-ID: <1252950234.23427.51.camel@johannes.local> (raw)
In-Reply-To: <200909141323.44245.hs4233@mail.mn-solutions.de>
[-- Attachment #1: Type: text/plain, Size: 2001 bytes --]
On Mon, 2009-09-14 at 13:23 +0200, Holger Schurig wrote:
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
>
> ---
>
> This fixes
>
> 1252921276.182218: Trying to associate with 00:1b:53:11:dc:40 (SSID='TEST' freq=2412 MHz)
> ioctl[SIOCSIWFREQ]: No such file or directory
> ioctl[SIOCSIWESSID]: No such file or directory
> 1252921276.268451: Association request to the driver failed
> 1252921276.355482: Associated with 00:1b:53:11:dc:40
>
> and makes it
>
> 1252921276.182218: Trying to associate with 00:1b:53:11:dc:40 (SSID='TEST' freq=2412 MHz)
> 1252921276.355482: Associated with 00:1b:53:11:dc:40
>
> However, otherwise this hasn't been greatly tested and I
> don't have a great understanding of cfg80211, SME, etc ...
And doesn't look correct to me at all. probably something missing wrt.
disconnect() while connecting.
johannes
> Index: linux-wl/net/wireless/wext-sme.c
> ===================================================================
> --- linux-wl.orig/net/wireless/wext-sme.c 2009-09-14 12:05:54.000000000 +0200
> +++ linux-wl/net/wireless/wext-sme.c 2009-09-14 12:06:09.000000000 +0200
> @@ -110,7 +110,7 @@ int cfg80211_mgd_wext_siwfreq(struct net
> goto out;
> }
>
> - err = cfg80211_mgd_wext_connect(rdev, wdev);
> + cfg80211_mgd_wext_connect(rdev, wdev);
> out:
> wdev_unlock(wdev);
> mutex_unlock(&rdev->devlist_mtx);
> @@ -196,7 +196,7 @@ int cfg80211_mgd_wext_siwessid(struct ne
>
> wdev->wext.connect.crypto.control_port = false;
>
> - err = cfg80211_mgd_wext_connect(rdev, wdev);
> + cfg80211_mgd_wext_connect(rdev, wdev);
> out:
> wdev_unlock(wdev);
> mutex_unlock(&rdev->devlist_mtx);
> @@ -283,7 +283,7 @@ int cfg80211_mgd_wext_siwap(struct net_d
> } else
> wdev->wext.connect.bssid = NULL;
>
> - err = cfg80211_mgd_wext_connect(rdev, wdev);
> + cfg80211_mgd_wext_connect(rdev, wdev);
> out:
> wdev_unlock(wdev);
> mutex_unlock(&rdev->devlist_mtx);
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-09-14 17:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-14 10:54 cfg80211_mgd_wext_connect() and wpa_supplicant don't like each other Holger Schurig
2009-09-14 11:23 ` [PATCH] cfg80211: don't report SME connection errs at SIOCSIW{FREQ/AP/ESSID} Holger Schurig
2009-09-14 17:43 ` Johannes Berg [this message]
2009-09-15 6:21 ` Holger Schurig
2009-09-16 4:39 ` Johannes Berg
2009-09-16 11:38 ` Holger Schurig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252950234.23427.51.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=hs4233@mail.mn-solutions.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox