From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <j@w1.fi>
Cc: Igor Perminov <igor.perminov@inbox.ru>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] mac80211: Fix [re]association power saving issue on AP side
Date: Sun, 27 Sep 2009 15:07:20 +0200 [thread overview]
Message-ID: <1254056840.6583.2.camel@johannes.local> (raw)
In-Reply-To: <20090926183446.GA10898@jm.kir.nu>
[-- Attachment #1: Type: text/plain, Size: 858 bytes --]
On Sat, 2009-09-26 at 21:34 +0300, Jouni Malinen wrote:
> On Tue, Sep 22, 2009 at 12:25:44AM +0400, Igor Perminov wrote:
>
> > At the step 4 the AP "remembers" the STA and considers it is still in
> > the PS state, so the AP buffers frames, which it has to send to the STA.
> > But the STA isn't actually in the PS state and so it neither checks
> > TIM bits nor reports to the AP that it isn't power saving.
> > Because of that authentication/[re]association fails.
> >
> > To fix authentication/[re]association stage of this issue, Auth, Assoc
> > Resp and Reassoc Resp frames are transmitted disregarding of STA's power
> > saving state.
>
> That looks fine to me and should be applied.
Alright, I'll take back my NACK then, just thought it'd be easier to do
the cleanup in the same patch but I can also do it separately.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2009-09-27 18:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-21 20:25 [PATCH v2] mac80211: Fix [re]association power saving issue on AP side Igor Perminov
2009-09-21 23:36 ` Johannes Berg
2009-09-26 18:34 ` Jouni Malinen
2009-09-27 13:07 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254056840.6583.2.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=igor.perminov@inbox.ru \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).