From: Ben Hutchings <bhutchings@solarflare.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
Kalle Valo <kalle.valo@nokia.com>, Kalle Valo <kalle.valo@iki.fi>,
"Luis R. Rodriguez" <mcgrof@gmail.com>
Subject: Re: [PATCH 1/3] wireless: implement basic ethtool support for cfg80211 devices
Date: Thu, 01 Oct 2009 02:30:38 +0100 [thread overview]
Message-ID: <1254360638.23350.0.camel@localhost> (raw)
In-Reply-To: <1254359942-3483-1-git-send-email-linville@tuxdriver.com>
On Wed, 2009-09-30 at 21:19 -0400, John W. Linville wrote:
[...]
> +void cfg80211_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
> +{
> + struct wireless_dev *wdev = dev->ieee80211_ptr;
> +
> + strncpy(info->driver, wiphy_dev(wdev->wiphy)->driver->name,
> + sizeof(info->driver));
> + info->driver[sizeof(info->driver) - 1] = '\0';
[...]
Use strlcpy() instead of these two statements.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2009-10-01 1:44 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-24 18:02 [PATCH 0/2] cfg80211: firmware and hardware version Kalle Valo
2009-09-24 18:02 ` [PATCH 1/2] cfg80211: add firmware and hardware version to wiphy Kalle Valo
2009-09-24 18:32 ` Luis R. Rodriguez
2009-09-24 19:14 ` Kalle Valo
2009-09-24 20:08 ` Luis R. Rodriguez
2009-09-24 18:02 ` [PATCH 2/2] at76c50x-usb: set firmware and hardware version in wiphy Kalle Valo
2009-09-24 18:35 ` Luis R. Rodriguez
2009-09-24 19:10 ` Kalle Valo
2009-09-24 20:11 ` Luis R. Rodriguez
2009-09-25 19:11 ` Kalle Valo
2009-09-25 19:27 ` Luis R. Rodriguez
2009-09-26 12:07 ` Johannes Berg
2009-09-26 13:59 ` Kalle Valo
2009-09-24 21:13 ` Joerg Albert
2009-09-25 19:06 ` Kalle Valo
2009-09-24 18:09 ` [PATCH 1/2] iw: update nl80211.h from wireless-testing Kalle Valo
2009-09-24 18:09 ` [PATCH 2/2] iw: print firmware and hardware version Kalle Valo
2009-09-24 20:20 ` [PATCH 0/2] cfg80211: " Luis R. Rodriguez
2009-09-25 4:42 ` John W. Linville
2009-09-25 16:47 ` Kalle Valo
2009-09-25 16:53 ` Luis R. Rodriguez
2009-10-01 1:13 ` John W. Linville
2009-10-01 1:19 ` [PATCH 1/3] wireless: implement basic ethtool support for cfg80211 devices John W. Linville
2009-10-01 1:19 ` [PATCH 2/3] cfg80211: add firmware and hardware version to wiphy John W. Linville
2009-10-01 1:19 ` [PATCH 3/3] at76c50x-usb: set firmware and hardware version in wiphy John W. Linville
2009-10-01 1:32 ` Ben Hutchings
2009-10-01 14:27 ` Kalle Valo
2009-10-01 1:30 ` Ben Hutchings [this message]
2009-10-01 8:51 ` [PATCH 1/3] wireless: implement basic ethtool support for cfg80211 devices Johannes Berg
2009-10-01 14:18 ` [PATCH 0/2] cfg80211: firmware and hardware version Kalle Valo
2009-10-01 15:18 ` John W. Linville
2009-10-01 15:33 ` Ben Hutchings
2009-10-01 16:56 ` John W. Linville
2009-10-01 16:20 ` Kalle Valo
2009-10-01 17:07 ` John W. Linville
2009-10-01 19:56 ` Luis R. Rodriguez
2009-10-01 20:12 ` Inaky Perez-Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254360638.23350.0.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=kalle.valo@iki.fi \
--cc=kalle.valo@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).