From: Johannes Berg <johannes@sipsolutions.net>
To: "Blaž Bačnik" <bacnik@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: VLAN traffic appearing on the wrong iface
Date: Thu, 01 Oct 2009 22:02:19 +0200 [thread overview]
Message-ID: <1254427339.3959.34.camel@johannes.local> (raw)
In-Reply-To: <57b62e7d0910011255r2ecf2bbex37422204add9a2b0@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 875 bytes --]
On Thu, 2009-10-01 at 21:55 +0200, Blaž Bačnik wrote:
> On Thu, Oct 1, 2009 at 8:39 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> > Thanks for looking into the crash -- I can't explain it.
> >
> >> - if (ieee80211_vif_is_mesh(&sdata->vif)) {
> >> + if (ieee80211_vif_is_mesh(&(*sta)->sdata->vif)) {
> >
> > However, that doesn't make any sense, given
> >
> > struct ieee80211_sub_if_data *sdata = (*sta)->sdata;
> >
> > Could the compiler be playing tricks on us?
>
> There's the sdata = container_of(sdata->bss, struct ieee80211_sub_if_data, u.ap)
> in if-clause right in front of the ieee80211_vif_is_mesh and since
> this is a vlan interface that if-clause gets executed.
Ahh. hwsim has no sta_notify callback. I'll amend my other patch
appropriately, since your fix is, while correct, kinda hard to
understand.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2009-10-01 20:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 0:54 VLAN traffic appearing on the wrong iface Blaž Bačnik
2009-09-30 17:51 ` Jouni Malinen
2009-09-30 20:16 ` Johannes Berg
2009-09-30 20:18 ` [PATCH 2.6.32] mac80211: fix vlan and optimise RX Johannes Berg
2009-10-01 20:06 ` [PATCH v2 " Johannes Berg
2009-10-01 14:32 ` VLAN traffic appearing on the wrong iface Blaž Bačnik
2009-10-01 14:40 ` Blaž Bačnik
2009-10-01 18:39 ` Johannes Berg
2009-10-01 19:55 ` Blaž Bačnik
2009-10-01 20:02 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254427339.3959.34.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=bacnik@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).