Re: [ath9k-devel] [RFT 0/4] ath9k: fix oops during driver unload

Luis R. Rodriguez
2009-10-06T15:59:28Z

On Tue, Oct 6, 2009 at 1:52 AM, Vasanthakumar Thiagarajan
<vasanth@atheros.com> wrote:
> On Tue, Oct 06, 2009 at 09:23:17AM +0530, Luis Rodriguez wrote:
>> This should fix an oops reported by Vasanth.
>> Vasanth my rc3 poos out, can you let me know if this
>> fixes the issue you saw?
>>
>> Luis R. Rodriguez (4):
>>   ath9k: move common->debug_mask setting to ath_init_softc()
>>   ath9k: fix oops during unload -- initialize hw prior to debugfs
>>   ath9k: add helper to un-init the hw properly
>>   ath9k: rename ath_beaconq_setup() to ath9k_hw_beaconq_setup()
>>
>>  drivers/net/wireless/ath/ath.h          |    6 ++++
>>  drivers/net/wireless/ath/ath9k/ath9k.h  |    1 -
>>  drivers/net/wireless/ath/ath9k/beacon.c |   12 -------
>>  drivers/net/wireless/ath/ath9k/debug.c  |    5 ---
>>  drivers/net/wireless/ath/ath9k/hw.c     |   11 ++++++-
>>  drivers/net/wireless/ath/ath9k/mac.c    |   13 ++++++++
>>  drivers/net/wireless/ath/ath9k/mac.h    |    1 +
>>  drivers/net/wireless/ath/ath9k/main.c   |   50 ++++++++++++++++++------------
>>  8 files changed, 60 insertions(+), 39 deletions(-)
>>
>
> The issue is not fixed completely, ah->common is used after ah is
> freed in ath_cleanup() which makes rmmod ath9k stuck in the middle.

Thanks I'll fix that as well.

Luis