From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] mac80211: fix logic error ibss merge bssid check
Date: Sun, 11 Oct 2009 11:43:16 +0200 [thread overview]
Message-ID: <1255254196.4095.44.camel@johannes.local> (raw)
In-Reply-To: <4AD14F26.6030304@openwrt.org>
[-- Attachment #1: Type: text/plain, Size: 623 bytes --]
On Sun, 2009-10-11 at 05:21 +0200, Felix Fietkau wrote:
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
>
> --- a/net/mac80211/ibss.c
> +++ b/net/mac80211/ibss.c
> @@ -544,7 +544,7 @@ static void ieee80211_sta_find_ibss(stru
> "%pM\n", bss->cbss.bssid, ifibss->bssid);
> #endif /* CONFIG_MAC80211_IBSS_DEBUG */
>
> - if (bss && memcmp(ifibss->bssid, bss->cbss.bssid, ETH_ALEN)) {
> + if (bss && !memcmp(ifibss->bssid, bss->cbss.bssid, ETH_ALEN)) {
Acked-by: Johannes Berg <johannes@sipsolutions.net>
I'll also send the race fix now, would appreciate you giving it a try.
Thanks,
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2009-10-11 9:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-11 3:21 [PATCH] mac80211: fix logic error ibss merge bssid check Felix Fietkau
2009-10-11 9:43 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255254196.4095.44.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).