Re: [PATCH 03/16] iwmc3200wifi: WPS support

[Marcel Holtmann <marcel@holtmann.org>]

Hi Yi,

> From: Samuel Ortiz <sameo@linux.intel.com>
> 
> By setting the WSC profile flag, we now support WPS as an enrollee.
> 
> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
> Signed-off-by: Zhu Yi <yi.zhu@intel.com>
> ---
>  drivers/net/wireless/iwmc3200wifi/cfg80211.c |    7 +++++++
>  drivers/net/wireless/iwmc3200wifi/commands.h |    3 +++
>  2 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/wireless/iwmc3200wifi/cfg80211.c b/drivers/net/wireless/iwmc3200wifi/cfg80211.c
> index 0d2e719..a6d2f20 100644
> --- a/drivers/net/wireless/iwmc3200wifi/cfg80211.c
> +++ b/drivers/net/wireless/iwmc3200wifi/cfg80211.c
> @@ -628,6 +628,13 @@ static int iwm_cfg80211_connect(struct wiphy *wiphy, struct net_device *dev,
>  		iwm->default_key = sme->key_idx;
>  	}
>  
> +	/* WPA and open AUTH type from wpa_s means WPS (a.k.a. WSC) */
> +	if ((iwm->umac_profile->sec.flags &
> +	     (UMAC_SEC_FLG_WPA_ON_MSK | UMAC_SEC_FLG_RSNA_ON_MSK)) &&
> +	    iwm->umac_profile->sec.auth_type == UMAC_AUTH_TYPE_OPEN) {
> +			iwm->umac_profile->sec.flags = UMAC_SEC_FLG_WSC_ON_MSK;
> +	}
> +

I don't wanna be picky, but what coding style are you following here?
The indentation makes no sense and doesn't improve readability.

Regards

Marcel