From: Dan Williams <dcbw@redhat.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: linux-wireless@vger.kernel.org, John Linville <linville@tuxdriver.com>
Subject: Re: [PATCH] libertas: remove unused lbs_cmd_802_11_inactivity_timeout()
Date: Fri, 16 Oct 2009 09:29:31 -0700 [thread overview]
Message-ID: <1255710571.14241.30.camel@localhost.localdomain> (raw)
In-Reply-To: <200910161734.22840.hs4233@mail.mn-solutions.de>
On Fri, 2009-10-16 at 17:34 +0200, Holger Schurig wrote:
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
We were going to use this at one point, but we haven't yet, so we can
add it back when we do.
Acked-by: Dan Williams <dcbw@redhat.com>
> --- linux-wl.orig/drivers/net/wireless/libertas/cmd.c
> +++ linux-wl/drivers/net/wireless/libertas/cmd.c
> @@ -273,33 +273,6 @@
> return 0;
> }
>
> -int lbs_cmd_802_11_inactivity_timeout(struct lbs_private *priv,
> - uint16_t cmd_action, uint16_t *timeout)
> -{
> - struct cmd_ds_802_11_inactivity_timeout cmd;
> - int ret;
> -
> - lbs_deb_enter(LBS_DEB_CMD);
> -
> - cmd.hdr.command = cpu_to_le16(CMD_802_11_INACTIVITY_TIMEOUT);
> - cmd.hdr.size = cpu_to_le16(sizeof(cmd));
> -
> - cmd.action = cpu_to_le16(cmd_action);
> -
> - if (cmd_action == CMD_ACT_SET)
> - cmd.timeout = cpu_to_le16(*timeout);
> - else
> - cmd.timeout = 0;
> -
> - ret = lbs_cmd_with_response(priv, CMD_802_11_INACTIVITY_TIMEOUT, &cmd);
> -
> - if (!ret)
> - *timeout = le16_to_cpu(cmd.timeout);
> -
> - lbs_deb_leave_args(LBS_DEB_CMD, "ret %d", ret);
> - return 0;
> -}
> -
> int lbs_cmd_802_11_sleep_params(struct lbs_private *priv, uint16_t cmd_action,
> struct sleep_params *sp)
> {
> --- linux-wl.orig/drivers/net/wireless/libertas/cmd.h
> +++ linux-wl/drivers/net/wireless/libertas/cmd.h
> @@ -135,9 +135,6 @@
> int lbs_cmd_802_11_rate_adapt_rateset(struct lbs_private *priv,
> uint16_t cmd_action);
>
> -int lbs_cmd_802_11_inactivity_timeout(struct lbs_private *priv,
> - uint16_t cmd_action, uint16_t *timeout);
> -
> int lbs_cmd_802_11_set_wep(struct lbs_private *priv, uint16_t cmd_action,
> struct assoc_request *assoc);
>
> --- linux-wl.orig/drivers/net/wireless/libertas/host.h
> +++ linux-wl/drivers/net/wireless/libertas/host.h
> @@ -621,16 +621,6 @@
> __le16 reserved;
> } __attribute__ ((packed));
>
> -struct cmd_ds_802_11_inactivity_timeout {
> - struct cmd_header hdr;
> -
> - /* ACT_GET/ACT_SET */
> - __le16 action;
> -
> - /* Inactivity timeout in msec */
> - __le16 timeout;
> -} __attribute__ ((packed));
> -
> struct cmd_ds_802_11_rf_channel {
> struct cmd_header hdr;
>
>
next prev parent reply other threads:[~2009-10-16 16:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-16 15:34 [PATCH] libertas: remove unused lbs_cmd_802_11_inactivity_timeout() Holger Schurig
2009-10-16 16:29 ` Dan Williams [this message]
2009-10-19 6:54 ` Holger Schurig
2009-10-21 18:12 ` Dan Williams
2009-10-22 7:28 ` Holger Schurig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255710571.14241.30.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox