From: Johannes Berg <johannes@sipsolutions.net>
To: Luciano Coelho <luciano.coelho@nokia.com>
Cc: linux-wireless@vger.kernel.org, kalle.valo@nokia.com,
juuso.oikarinen@nokia.com
Subject: Re: [RFC 1/3] mac80211: WIP - add operating BSSID to device configuration struct
Date: Thu, 22 Oct 2009 10:55:19 +0200 [thread overview]
Message-ID: <1256201719.12174.19.camel@johannes.local> (raw)
In-Reply-To: <1255696042-28413-2-git-send-email-luciano.coelho@nokia.com>
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
On Fri, 2009-10-16 at 15:27 +0300, Luciano Coelho wrote:
> @@ -2405,7 +2411,15 @@ int ieee80211_mgd_auth(struct ieee80211_sub_if_data *sdata,
> * to sleep and then change channel etc.
> */
> sdata->local->oper_channel = req->bss->channel;
> - ieee80211_hw_config(sdata->local, 0);
> +
> + if (memcmp(sdata->local->hw.conf.oper_bssid,
> + req->bss->bssid, ETH_ALEN)) {
> + config_changed |= IEEE80211_CONF_CHANGE_OPER_BSSID;
> + memcpy(sdata->local->hw.conf.oper_bssid,
> + req->bss->bssid, ETH_ALEN);
> + }
> +
> + ieee80211_hw_config(sdata->local, config_changed);
>
Is this really necessary before you can auth?
If it is, you're going to have to do a lot more work and go all the way
up to userspace so wpa_supplicant with -Dnl80211 knows about this too,
and doesn't try to authenticate twice or do FT-OTA.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-10-23 13:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-16 12:27 [RFC 0/3] mac80211 operating bssid concept implementation Luciano Coelho
2009-10-16 12:27 ` [RFC 1/3] mac80211: WIP - add operating BSSID to device configuration struct Luciano Coelho
2009-10-22 8:55 ` Johannes Berg [this message]
2009-10-24 5:34 ` Luciano Coelho
2009-10-26 8:37 ` Kalle Valo
2009-10-26 9:10 ` Luciano Coelho
2009-10-26 9:28 ` Kalle Valo
2009-10-26 9:52 ` Luciano Coelho
2009-10-26 8:19 ` Kalle Valo
2009-10-26 9:11 ` Luciano Coelho
2009-10-16 12:27 ` [RFC 2/3] wl1271: WIP - use operating BSSID for joining and disconnecting Luciano Coelho
2009-10-16 12:27 ` [RFC 3/3] wl1271: WIP - remove workaround for disconnection Luciano Coelho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256201719.12174.19.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=juuso.oikarinen@nokia.com \
--cc=kalle.valo@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).