From: Reinette Chatre <reinette.chatre@intel.com>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net,
Wey-Yi Guy <wey-yi.w.guy@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>
Subject: [PATCH 04/18] iwlwifi: separate led function from statistic notification
Date: Fri, 23 Oct 2009 13:42:22 -0700 [thread overview]
Message-ID: <1256330556-20997-5-git-send-email-reinette.chatre@intel.com> (raw)
In-Reply-To: <1256330556-20997-1-git-send-email-reinette.chatre@intel.com>
From: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Detach led background task from statistic notification routine. if led
blinking is required; the blink rate is based on the traffic condition.
It do not relate to statistics notification. In addition to that, there is
not a requirement for statistics notification has to occur all the time.
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
---
drivers/net/wireless/iwlwifi/iwl-3945.c | 2 --
drivers/net/wireless/iwlwifi/iwl-agn.c | 2 ++
drivers/net/wireless/iwlwifi/iwl-rx.c | 3 ---
3 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
index 7142aa5..269b988 100644
--- a/drivers/net/wireless/iwlwifi/iwl-3945.c
+++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
@@ -359,8 +359,6 @@ void iwl3945_hw_rx_statistics(struct iwl_priv *priv,
le32_to_cpu(pkt->len_n_flags) & FH_RSCSR_FRAME_SIZE_MSK);
memcpy(&priv->statistics_39, pkt->u.raw, sizeof(priv->statistics_39));
-
- iwl_leds_background(priv);
}
/******************************************************************************
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
index 64d9187..a34acb7 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
@@ -1019,6 +1019,7 @@ static void iwl_irq_tasklet_legacy(struct iwl_priv *priv)
if (inta & (CSR_INT_BIT_FH_RX | CSR_INT_BIT_SW_RX)) {
iwl_rx_handle(priv);
priv->isr_stats.rx++;
+ iwl_leds_background(priv);
handled |= (CSR_INT_BIT_FH_RX | CSR_INT_BIT_SW_RX);
}
@@ -1220,6 +1221,7 @@ static void iwl_irq_tasklet(struct iwl_priv *priv)
CSR_INT_PERIODIC_ENA);
priv->isr_stats.rx++;
+ iwl_leds_background(priv);
}
if (inta & CSR_INT_BIT_FH_TX) {
diff --git a/drivers/net/wireless/iwlwifi/iwl-rx.c b/drivers/net/wireless/iwlwifi/iwl-rx.c
index 0a407f7..cfc31ae 100644
--- a/drivers/net/wireless/iwlwifi/iwl-rx.c
+++ b/drivers/net/wireless/iwlwifi/iwl-rx.c
@@ -627,9 +627,6 @@ void iwl_rx_statistics(struct iwl_priv *priv,
iwl_rx_calc_noise(priv);
queue_work(priv->workqueue, &priv->run_time_calib_work);
}
-
- iwl_leds_background(priv);
-
if (priv->cfg->ops->lib->temp_ops.temperature && change)
priv->cfg->ops->lib->temp_ops.temperature(priv);
}
--
1.5.6.3
next prev parent reply other threads:[~2009-10-23 20:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-23 20:42 [PATCH 00/18] iwlwifi updates 10/23/2009 Reinette Chatre
2009-10-23 20:42 ` [PATCH 01/18] iwlwifi: add missing commands to syslog messages Reinette Chatre
2009-10-23 20:42 ` [PATCH 02/18] iwlwifi: fix gain computation for 5000 series and up Reinette Chatre
2009-10-23 20:42 ` [PATCH 03/18] iwlwifi: consolidate apm_init() functions Reinette Chatre
2009-10-23 20:42 ` Reinette Chatre [this message]
2009-10-23 20:42 ` [PATCH 05/18] iwlwifi: update bt co-exit configuration parameter Reinette Chatre
2009-10-23 20:42 ` [PATCH 06/18] iwlwifi: specify the valid tx/rx chain in device config structure Reinette Chatre
2009-10-23 20:42 ` [PATCH 07/18] iwlwifi: fix use after free bug for paged rx Reinette Chatre
2009-10-23 20:42 ` [PATCH 08/18] iwlwifi: increase max tfd payload size Reinette Chatre
2009-10-23 20:42 ` [PATCH 09/18] iwlwifi: choose thermal throttle method based on device config Reinette Chatre
2009-10-23 20:42 ` [PATCH 10/18] iwlwifi: issue ct_kill host command " Reinette Chatre
2009-10-23 20:42 ` [PATCH 11/18] iwlwifi: add channel switch support to 5000 series and up Reinette Chatre
2009-10-23 20:42 ` [PATCH 12/18] iwlwifi: remove duplicate defines Reinette Chatre
2009-10-23 20:42 ` [PATCH 13/18] iwlwifi: remove unused parameters Reinette Chatre
2009-10-23 20:42 ` [PATCH 14/18] iwlwifi: reuse page for notification packets Reinette Chatre
2009-10-23 20:42 ` [PATCH 15/18] iwlwifi: remove duplicated define Reinette Chatre
2009-10-23 20:42 ` [PATCH 16/18] iwlwifi: update lowest API version support for 6x00 & 6x50 series Reinette Chatre
2009-10-23 20:42 ` [PATCH 17/18] iwlwifi: make sure device is reset when unloading driver Reinette Chatre
2009-10-23 20:42 ` [PATCH 18/18] iwlwifi: minor comments changes for wimax co-exist command Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256330556-20997-5-git-send-email-reinette.chatre@intel.com \
--to=reinette.chatre@intel.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox