From: Dan Williams <dcbw@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Andrey Yurovsky <andrey@cozybit.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: libertas sdio firmware
Date: Mon, 26 Oct 2009 13:02:21 -0700 [thread overview]
Message-ID: <1256587341.2110.18.camel@localhost.localdomain> (raw)
In-Reply-To: <1256541398.28230.2.camel@johannes.local>
On Mon, 2009-10-26 at 08:16 +0100, Johannes Berg wrote:
> Hi,
>
> Was just looking at the libertas driver and noticed that the SPI part
> loads firmware as such:
>
> snprintf(helper_fw, IF_SPI_FW_NAME_MAX, "libertas/gspi%d_hlp.bin", ...
> etc.
>
> while the SDIO part just uses
> ret = request_firmware(&fw, card->helper, &card->func->dev);
>
> which ends up requesting sd8686_helper.bin instead of
> libertas/sd8686_helper.bin, as far as I can tell. That means the
> linux-firmware git repo won't work out of the box, I think?
Correct. I stuffed all the firmware into the git repo that I could
find, but because I didn't quite get around to doing firmware name
fallbacks in the driver (so we don't break existing installs) the driver
hasn't been updated yet.
I'd like to do a couple fallbacks actually; something like a priority
ordering of [<old name>, libertas/sd8686_helper_v9.bin,
libertas/sd8686_helper_v8.bin] so that we can use either v8 and v9
firmware if we need to; not all the v9 functionality has been added yet.
v10 is out there too but I haven't seen it in the wild yet.
Dan
prev parent reply other threads:[~2009-10-26 20:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 7:16 libertas sdio firmware Johannes Berg
2009-10-26 20:02 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256587341.2110.18.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=andrey@cozybit.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox