From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-wireless-owner@vger.kernel.org>
Received: from senator.holtmann.net ([87.106.208.187]:48472 "EHLO
	mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752390AbZJ2N6l (ORCPT
	<rfc822;linux-wireless@vger.kernel.org>);
	Thu, 29 Oct 2009 09:58:41 -0400
Subject: Re: [PATCH] firmware_class: make request_firmware_nowait more
 useful
From: Marcel Holtmann <marcel@holtmann.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Greg KH <gregkh@suse.de>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Ming Lei <tom.leiming@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	David Woodhouse <David.Woodhouse@intel.com>,
	Pavel Roskin <proski@gnu.org>,
	Abhay Salunke <abhay_salunke@dell.com>
In-Reply-To: <1256816162.3865.110.camel@johannes.local>
References: <1256816162.3865.110.camel@johannes.local>
Content-Type: text/plain
Date: Thu, 29 Oct 2009 22:58:12 +0900
Message-Id: <1256824692.5768.41.camel@localhost.localdomain>
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org
List-ID: <linux-wireless.vger.kernel.org>

Hi Johannes,

> Unfortunately, one cannot hold on to the struct firmware
> that request_firmware_nowait() hands off, which is needed
> in some cases. Allow this by requiring the callback to
> free it (via release_firmware).
> 
> Additionally, give it a gfp_t parameter -- all the current
> users call it from a GFP_KERNEL context so the GFP_ATOMIC
> isn't necessary. This also marks an API break which is
> useful in a sense, although that is obviously not the
> primary purpose of this change.
> 
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

I had a look at this one and looks good to me and makes perfect sense.

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel