Re: [PATCH 08/15] iwlwifi: move iwl_[un]init_drv to iwlagn

[reinette chatre <reinette.chatre@intel.com>]

Hi Johannes,

On Fri, 2009-10-30 at 22:56 -0700, Johannes Berg wrote:
> On Fri, 2009-10-30 at 14:36 -0700, Reinette Chatre wrote:
> > From: Reinette Chatre <reinette.chatre@intel.com>
> > 
> > Since iwlagn is the only user of these functions, move it to this module.
> > This results in a bit more code moving than just these functions since the
> > functions only used by them are also moved and we need to export the
> > symbols previously available to them directly.
> 
> The last bit (export previously available symbols) doesn't seem to make
> sense -- if they weren't exported before then surely 3945 doesn't use
> them so they could be moved as well? Unless maybe they're used by other
> functions that _are_ used by 3945?

What happened in this patch is that I moved a function from iwlcore to
iwlagn. This function, while in iwlcore, had access to all the symbols
in iwlcore. Now that I moved the function to iwlagn I needed to make
sure all symbols needed by it was available. This resulted in me
exporting iwl_calib_free_results and iwl_init_scan_params since they are
in iwlcore and are now called by this function in iwlagn.

Reinette