From: Dan Williams <dcbw@redhat.com>
To: Holger Schurig <holgerschurig@googlemail.com>
Cc: Ben Hutchings <ben@decadent.org.uk>,
linux-wireless <linux-wireless@vger.kernel.org>,
John Linville <linville@tuxdriver.com>,
libertas-dev@lists.infradead.org
Subject: Re: [PATCH 50/75] libertas: declare MODULE_FIRMWARE
Date: Mon, 09 Nov 2009 22:32:54 -0800 [thread overview]
Message-ID: <1257834774.15493.34.camel@localhost.localdomain> (raw)
In-Reply-To: <m37hu09l4h.wl%holgerschurig@gmail.com>
On Mon, 2009-11-09 at 09:07 +0100, Holger Schurig wrote:
> At Sat, 07 Nov 2009 22:00:03 +0000,
> Ben Hutchings wrote:
> > diff --git a/drivers/net/wireless/libertas/if_cs.c b/drivers/net/wireless/libertas/if_cs.c
> > index 9127d2a..9834e3f 100644
> > --- a/drivers/net/wireless/libertas/if_cs.c
> > +++ b/drivers/net/wireless/libertas/if_cs.c
> > @@ -48,6 +48,7 @@
> > MODULE_AUTHOR("Holger Schurig <hs4233@mail.mn-solutions.de>");
> > MODULE_DESCRIPTION("Driver for Marvell 83xx compact flash WLAN cards");
> > MODULE_LICENSE("GPL");
> > +MODULE_FIRMWARE("libertas_cs_helper.fw");
>
> Do you intentionally only define specify the helper firmware? The
> device won't be working without loading "libertas_cs.fw" as well.
>
> Do you have any pointer for me to what MDOULE_FIRMWARE does? What
> user-space tool does it it for what purpose?
It's nice information to know from 'modinfo' or other uses so that we
might be able to find the firmware automatically. Right now actually
PackageKit will figure out missing firmware from udev when udev can't
find the right firmware, but having it in 'modinfo' is useful too.
Honestly I think we should actually reorganize the firmware and put it
in /lib/firmware/libertas or something.
Dan
prev parent reply other threads:[~2009-11-10 6:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-07 22:00 [PATCH 50/75] libertas: declare MODULE_FIRMWARE Ben Hutchings
2009-11-09 8:07 ` Holger Schurig
2009-11-10 6:32 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257834774.15493.34.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=ben@decadent.org.uk \
--cc=holgerschurig@googlemail.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).