From: Dan Williams <dcbw@redhat.com>
To: Bing Zhao <bzhao@marvell.com>
Cc: libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
Amitkumar Karwar <akarwar@marvell.com>
Subject: Re: [PATCH 1/2] Libertas: coding style cleanup in ethtool.c
Date: Mon, 09 Nov 2009 22:33:24 -0800 [thread overview]
Message-ID: <1257834804.15493.35.camel@localhost.localdomain> (raw)
In-Reply-To: <1257818653-13460-1-git-send-email-bzhao@marvell.com>
On Mon, 2009-11-09 at 18:04 -0800, Bing Zhao wrote:
> Signed-off-by: Bing Zhao <bzhao@marvell.com>
Acked-by: Dan Williams <dcbw@redhat.com>
> ---
> drivers/net/wireless/libertas/ethtool.c | 12 ++++++++----
> 1 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/libertas/ethtool.c b/drivers/net/wireless/libertas/ethtool.c
> index 039b555..6efa388 100644
> --- a/drivers/net/wireless/libertas/ethtool.c
> +++ b/drivers/net/wireless/libertas/ethtool.c
> @@ -175,10 +175,14 @@ static int lbs_ethtool_set_wol(struct net_device *dev,
> if (wol->wolopts & ~(WAKE_UCAST|WAKE_MCAST|WAKE_BCAST|WAKE_PHY))
> return -EOPNOTSUPP;
>
> - if (wol->wolopts & WAKE_UCAST) criteria |= EHS_WAKE_ON_UNICAST_DATA;
> - if (wol->wolopts & WAKE_MCAST) criteria |= EHS_WAKE_ON_MULTICAST_DATA;
> - if (wol->wolopts & WAKE_BCAST) criteria |= EHS_WAKE_ON_BROADCAST_DATA;
> - if (wol->wolopts & WAKE_PHY) criteria |= EHS_WAKE_ON_MAC_EVENT;
> + if (wol->wolopts & WAKE_UCAST)
> + criteria |= EHS_WAKE_ON_UNICAST_DATA;
> + if (wol->wolopts & WAKE_MCAST)
> + criteria |= EHS_WAKE_ON_MULTICAST_DATA;
> + if (wol->wolopts & WAKE_BCAST)
> + criteria |= EHS_WAKE_ON_BROADCAST_DATA;
> + if (wol->wolopts & WAKE_PHY)
> + criteria |= EHS_WAKE_ON_MAC_EVENT;
>
> return lbs_host_sleep_cfg(priv, criteria, (struct wol_config *)NULL);
> }
prev parent reply other threads:[~2009-11-10 6:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 2:04 [PATCH 1/2] Libertas: coding style cleanup in ethtool.c Bing Zhao
2009-11-10 2:04 ` [PATCH 2/2] Libertas: fix issues while configuring host sleep using ethtool wol Bing Zhao
2009-11-10 6:33 ` Dan Williams
2009-11-10 6:33 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257834804.15493.35.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=akarwar@marvell.com \
--cc=bzhao@marvell.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox