linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Holger Schurig <holgerschurig@googlemail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] cfg80211: survey report capability
Date: Tue, 10 Nov 2009 11:20:59 +0100	[thread overview]
Message-ID: <1257848459.7037.32.camel@johannes.local> (raw)
In-Reply-To: <1257848249.7037.30.camel@johannes.local>

[-- Attachment #1: Type: text/plain, Size: 945 bytes --]

On Tue, 2009-11-10 at 11:17 +0100, Johannes Berg wrote:

> Right now you're retrieving a single channel but can't even control
> which one. Maybe that's useful functionality in addition to dump when
> you _can_ ask for information on a specific channel, but that'd have to
> pass in the frequency from userspace.
> 
> Retrieving all data like you've implemented (though I guess you forgot
> the multiple channels case) should be a dump. Maybe that's sufficient
> since there won't be huge amounts of data and userspace can just pick
> out what it needs from the dump.

And maybe the get_survey() driver call can actually pass in the channel
pointer ... then the drivers/mac80211 don't need to implement both
get_survey() and dump_survey() since cfg80211 knows the valid channel
list anyway. But that means iterating over the channel list all the
time, even if the driver can only return values for a single channel.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  reply	other threads:[~2009-11-10 10:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-10  9:48 [RFC] cfg80211: survey report capability Holger Schurig
2009-11-10 10:03 ` Holger Schurig
2009-11-10 10:17 ` Johannes Berg
2009-11-10 10:20   ` Johannes Berg [this message]
2009-11-10 11:19   ` Holger Schurig
2009-11-10 12:08     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1257848459.7037.32.camel@johannes.local \
    --to=johannes@sipsolutions.net \
    --cc=holgerschurig@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).