From: Marcel Holtmann <marcel@holtmann.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Matthew Garrett <mjg@redhat.com>,
linux-input@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] input: Add KEY_RFKILL
Date: Fri, 13 Nov 2009 06:34:26 +0100 [thread overview]
Message-ID: <1258090466.3299.6.camel@violet> (raw)
In-Reply-To: <20090911051259.GC23210@core.coreip.homeip.net>
Hi Matthew,
> > Most laptops have keys that are intended to toggle all device state, not
> > just wifi. These are currently generally mapped to KEY_WLAN. As a result,
> > rfkill will only kill or enable wifi in response to the key press. This
> > confuses users and can make it difficult for them to enable bluetooth
> > and wwan devices.
> >
> > This patch adds a new keycode, KEY_RFKILL_ALL. It indicates that the
>
> The new name in description does not match the code...
>
> > system should toggle the state of all rfkillable devices.
>
> Hmm, rfkill changes usually go through net tree so unless they want me
> to push it though I'll just ACK the new keycode.
>
> >
> > Signed-off-by: Matthew Garrett <mjg@redhat.com>
>
> Acked-by: Dmitry Torokhov <dtor@mail.ru>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
next prev parent reply other threads:[~2009-11-13 5:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-10 17:21 [PATCH 1/2] input: Add KEY_RFKILL Matthew Garrett
2009-09-10 17:21 ` [PATCH 2/2] rfkill: Add support for KEY_RFKILL Matthew Garrett
2009-11-13 5:33 ` Marcel Holtmann
2009-09-10 17:27 ` [PATCH 1/2] input: Add KEY_RFKILL Luis R. Rodriguez
2009-09-10 17:31 ` Matthew Garrett
2009-09-11 5:13 ` Dmitry Torokhov
2009-11-13 5:34 ` Marcel Holtmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-02-16 21:36 Matthew Garrett
2010-02-16 23:05 ` Marcel Holtmann
2010-02-17 5:22 ` Dmitry Torokhov
2010-02-17 18:03 ` Matthew Garrett
2010-02-17 18:43 ` Christian Lamparter
2010-02-17 18:45 ` Matthew Garrett
2010-02-17 18:49 ` Bastien Nocera
2010-02-17 22:34 ` Peter Hutterer
2010-02-18 4:16 ` Dmitry Torokhov
2010-02-18 4:29 ` Peter Hutterer
2010-02-17 19:18 ` Christian Lamparter
2010-02-17 19:17 ` Dmitry Torokhov
2010-02-17 19:42 ` Christian Lamparter
2010-02-17 19:54 ` Dmitry Torokhov
2010-02-17 20:02 ` Matthew Garrett
2010-02-17 20:49 ` Dmitry Torokhov
2010-02-17 20:50 ` Matthew Garrett
2010-02-17 20:18 ` Christian Lamparter
2010-02-17 20:52 ` Dmitry Torokhov
2010-02-17 21:12 ` pat-lkml
2010-02-17 21:28 ` Christian Lamparter
2010-02-17 21:40 ` Dmitry Torokhov
2010-02-17 22:03 ` Christian Lamparter
2010-02-20 9:18 ` Dmitry Torokhov
2010-02-19 14:33 ` Henrique de Moraes Holschuh
2010-02-17 19:18 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258090466.3299.6.camel@violet \
--to=marcel@holtmann.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mjg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).