From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"Luis R. Rodriguez" <mcgrof@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH 1/2] mac80211: add private driver flags and ampdu length to tx info
Date: Sun, 15 Nov 2009 15:01:46 +0100 [thread overview]
Message-ID: <1258293706.6294.7.camel@johannes.local> (raw)
In-Reply-To: <4AFED564.8030804@openwrt.org>
[-- Attachment #1: Type: text/plain, Size: 748 bytes --]
On Sat, 2009-11-14 at 17:05 +0100, Felix Fietkau wrote:
> - * @ampdu_ack_len: number of aggregated frames.
> - * relevant only if IEEE80211_TX_STATUS_AMPDU was set.
> + * @ampdu_ack_len: number of acked aggregated frames.
> + * relevant only if ieee80211_tx_status_ampdu was set.
why lowercase that?
> - /* 2 byte hole */
> - u8 pad[2];
> + u8 driver_flags;
> + u8 pad;
The ampdu_len seems ok, but I'm still not convinced this is right.
Drivers _should_ have enough space in the driver parts of this struct,
and not need flags here. I realise that you do need that because of the
RC and other internal things, but maybe you could simply use "pad[0]"
for that so not to encourage others to start doing this too?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-11-15 14:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-14 16:05 [PATCH 1/2] mac80211: add private driver flags and ampdu length to tx info Felix Fietkau
2009-11-14 16:08 ` [PATCH 2/2] ath9k: get rid of tx_info_priv Felix Fietkau
2009-11-15 14:01 ` Johannes Berg [this message]
2009-11-15 14:19 ` [PATCH 1/2] mac80211: add private driver flags and ampdu length to tx info Felix Fietkau
2009-11-15 14:27 ` Johannes Berg
2009-11-15 14:36 ` Felix Fietkau
2009-11-15 15:00 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258293706.6294.7.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).