* [patch 0/1] Adding radio type FM
@ 2009-11-13 3:09 Janakiram Sistla
2009-11-13 3:09 ` John W. Linville
2009-11-13 3:22 ` Marcel Holtmann
0 siblings, 2 replies; 21+ messages in thread
From: Janakiram Sistla @ 2009-11-13 3:09 UTC (permalink / raw)
To: majordomo; +Cc: linux-wireless, linux-kernel
>From 1b1493392faeb6702ff364447b135e481930b397 Mon Sep 17 00:00:00 2001
From: Janakiram Sistla <janakiram.sistla@gmail.com>
Date: Fri, 13 Nov 2009 08:16:26 +0530
Subject: [PATCH 1/1] Adding radio type FM
Adding radio type FM in RFKILL_TYPE_.FM also belongs to
same class of with both TX/RX capability.
Also Added input type for the above same.
Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
---
include/linux/input.h | 1 +
include/linux/rfkill.h | 1 +
net/rfkill/core.c | 2 ++
net/rfkill/input.c | 9 +++++++++
4 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/include/linux/input.h b/include/linux/input.h
index 0ccfc30..f03ae90 100644
--- a/include/linux/input.h
+++ b/include/linux/input.h
@@ -376,6 +376,7 @@ struct input_absinfo {
#define KEY_DISPLAY_OFF 245 /* display device to off state */
#define KEY_WIMAX 246
+#define KEY_FM 247
/* Range 248 - 255 is reserved for special needs of AT keyboard driver */
diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index 3392c59..03f5598 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -45,6 +45,7 @@ enum rfkill_type {
RFKILL_TYPE_WIMAX,
RFKILL_TYPE_WWAN,
RFKILL_TYPE_GPS,
+ RFKILL_TYPE_FM,
NUM_RFKILL_TYPES,
};
diff --git a/net/rfkill/core.c b/net/rfkill/core.c
index ba2efb9..b8ac206 100644
--- a/net/rfkill/core.c
+++ b/net/rfkill/core.c
@@ -592,6 +592,8 @@ static const char *rfkill_get_type_str(enum
rfkill_type type)
return "wwan";
case RFKILL_TYPE_GPS:
return "gps";
+ case RRFKILL_TYPE_FM:
+ return "fm";
default:
BUG();
}
diff --git a/net/rfkill/input.c b/net/rfkill/input.c
index a7295ad..f51b16d 100644
--- a/net/rfkill/input.c
+++ b/net/rfkill/input.c
@@ -212,6 +212,9 @@ static void rfkill_event(struct input_handle
*handle, unsigned int type,
case KEY_WIMAX:
rfkill_schedule_toggle(RFKILL_TYPE_WIMAX);
break;
+ case KEY_FM:
+ rfkill_schedule_toggle(RFKILL_TYPE_FM);
+ break;
}
} else if (type == EV_SW && code == SW_RFKILL_ALL)
rfkill_schedule_evsw_rfkillall(data);
@@ -290,6 +293,12 @@ static const struct input_device_id rfkill_ids[] = {
.keybit = { [BIT_WORD(KEY_UWB)] = BIT_MASK(KEY_UWB) },
},
{
+ .flags = INPUT_DEVICE_ID_MATCH_EVBIT |
+ INPUT_DEVICE_ID_MATCH_KEYBIT,
+ .evbit = { BIT_MASK(EV_KEY) },
+ .keybit = { [BIT_WORD(KEY_UWB)] = BIT_MASK(KEY_UWB) },
+ },
+ {
.flags = INPUT_DEVICE_ID_MATCH_EVBIT | INPUT_DEVICE_ID_MATCH_KEYBIT,
.evbit = { BIT_MASK(EV_KEY) },
.keybit = { [BIT_WORD(KEY_WIMAX)] = BIT_MASK(KEY_WIMAX) },
--
1.5.4.3
Regards,
Janakiram.
janakiram.sistla@gmail.com
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [patch 0/1] Adding radio type FM
2009-11-13 3:09 [patch 0/1] Adding radio type FM Janakiram Sistla
@ 2009-11-13 3:09 ` John W. Linville
2009-11-13 3:25 ` Janakiram Sistla
2009-11-13 3:22 ` Marcel Holtmann
1 sibling, 1 reply; 21+ messages in thread
From: John W. Linville @ 2009-11-13 3:09 UTC (permalink / raw)
To: Janakiram Sistla; +Cc: majordomo, linux-wireless, linux-kernel
On Fri, Nov 13, 2009 at 08:39:27AM +0530, Janakiram Sistla wrote:
> From 1b1493392faeb6702ff364447b135e481930b397 Mon Sep 17 00:00:00 2001
> From: Janakiram Sistla <janakiram.sistla@gmail.com>
> Date: Fri, 13 Nov 2009 08:16:26 +0530
> Subject: [PATCH 1/1] Adding radio type FM
>
> Adding radio type FM in RFKILL_TYPE_.FM also belongs to
> same class of with both TX/RX capability.
> Also Added input type for the above same.
>
> Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
> @@ -290,6 +293,12 @@ static const struct input_device_id rfkill_ids[] = {
> .keybit = { [BIT_WORD(KEY_UWB)] = BIT_MASK(KEY_UWB) },
> },
> {
> + .flags = INPUT_DEVICE_ID_MATCH_EVBIT |
> + INPUT_DEVICE_ID_MATCH_KEYBIT,
> + .evbit = { BIT_MASK(EV_KEY) },
> + .keybit = { [BIT_WORD(KEY_UWB)] = BIT_MASK(KEY_UWB) },
> + },
Surely this should be KEY_FM?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [patch 0/1] Adding radio type FM
2009-11-13 3:09 ` John W. Linville
@ 2009-11-13 3:25 ` Janakiram Sistla
2009-11-13 3:29 ` Julian Calaby
0 siblings, 1 reply; 21+ messages in thread
From: Janakiram Sistla @ 2009-11-13 3:25 UTC (permalink / raw)
To: John W. Linville; +Cc: majordomo, linux-wireless, linux-kernel
Resending with added comments from John.
>From 1b1493392faeb6702ff364447b135e481930b397 Mon Sep 17 00:00:00 2001
From: Janakiram Sistla <janakiram.sistla@gmail.com>
Date: Fri, 13 Nov 2009 08:16:26 +0530
Subject: [PATCH 1/1] Adding radio type FM
Adding radio type FM in RFKILL_TYPE_.FM also belongs to
same class of with both TX/RX capability.
Also Added input type for the above same.
Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
---
include/linux/input.h | 1 +
include/linux/rfkill.h | 1 +
net/rfkill/core.c | 2 ++
net/rfkill/input.c | 9 +++++++++
4 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/include/linux/input.h b/include/linux/input.h
index 0ccfc30..f03ae90 100644
--- a/include/linux/input.h
+++ b/include/linux/input.h
@@ -376,6 +376,7 @@ struct input_absinfo {
#define KEY_DISPLAY_OFF 245 /* display device to off state */
#define KEY_WIMAX 246
+#define KEY_FM 247
/* Range 248 - 255 is reserved for special needs of AT keyboard driver */
diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index 3392c59..03f5598 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -45,6 +45,7 @@ enum rfkill_type {
RFKILL_TYPE_WIMAX,
RFKILL_TYPE_WWAN,
RFKILL_TYPE_GPS,
+ RFKILL_TYPE_FM,
NUM_RFKILL_TYPES,
};
diff --git a/net/rfkill/core.c b/net/rfkill/core.c
index ba2efb9..b8ac206 100644
--- a/net/rfkill/core.c
+++ b/net/rfkill/core.c
@@ -592,6 +592,8 @@ static const char *rfkill_get_type_str(enum
rfkill_type type)
return "wwan";
case RFKILL_TYPE_GPS:
return "gps";
+ case RRFKILL_TYPE_FM:
+ return "fm";
default:
BUG();
}
diff --git a/net/rfkill/input.c b/net/rfkill/input.c
index a7295ad..f51b16d 100644
--- a/net/rfkill/input.c
+++ b/net/rfkill/input.c
@@ -212,6 +212,9 @@ static void rfkill_event(struct input_handle
*handle, unsigned int type,
case KEY_WIMAX:
rfkill_schedule_toggle(RFKILL_TYPE_WIMAX);
break;
+ case KEY_FM:
+ rfkill_schedule_toggle(RFKILL_TYPE_FM);
+ break;
}
} else if (type == EV_SW && code == SW_RFKILL_ALL)
rfkill_schedule_evsw_rfkillall(data);
@@ -290,6 +293,12 @@ static const struct input_device_id rfkill_ids[] = {
.keybit = { [BIT_WORD(KEY_UWB)] = BIT_MASK(KEY_UWB) },
},
{
+ .flags = INPUT_DEVICE_ID_MATCH_EVBIT |
+ INPUT_DEVICE_ID_MATCH_KEYBIT,
+ .evbit = { BIT_MASK(EV_KEY) },
+ .keybit = { [BIT_WORD(KEY_FM)] = BIT_MASK(KEY_UWB) },
+ },
+ {
.flags = INPUT_DEVICE_ID_MATCH_EVBIT | INPUT_DEVICE_ID_MATCH_KEYBIT,
.evbit = { BIT_MASK(EV_KEY) },
.keybit = { [BIT_WORD(KEY_WIMAX)] = BIT_MASK(KEY_WIMAX) },
--
1.5.4.3
Regards,
Ram.
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [patch 0/1] Adding radio type FM
2009-11-13 3:25 ` Janakiram Sistla
@ 2009-11-13 3:29 ` Julian Calaby
2009-11-13 3:41 ` Marcel Holtmann
0 siblings, 1 reply; 21+ messages in thread
From: Julian Calaby @ 2009-11-13 3:29 UTC (permalink / raw)
To: Janakiram Sistla
Cc: John W. Linville, majordomo, linux-wireless, linux-kernel
On Fri, Nov 13, 2009 at 14:25, Janakiram Sistla
<janakiram.sistla@gmail.com> wrote:
> Resending with added comments from John.
> From 1b1493392faeb6702ff364447b135e481930b397 Mon Sep 17 00:00:00 2001
> From: Janakiram Sistla <janakiram.sistla@gmail.com>
> Date: Fri, 13 Nov 2009 08:16:26 +0530
> Subject: [PATCH 1/1] Adding radio type FM
>
> Adding radio type FM in RFKILL_TYPE_.FM also belongs to
> same class of with both TX/RX capability.
> Also Added input type for the above same.
>
> Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
> ---
> include/linux/input.h | 1 +
> include/linux/rfkill.h | 1 +
> net/rfkill/core.c | 2 ++
> net/rfkill/input.c | 9 +++++++++
> 4 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/input.h b/include/linux/input.h
> index 0ccfc30..f03ae90 100644
> --- a/include/linux/input.h
> +++ b/include/linux/input.h
> @@ -376,6 +376,7 @@ struct input_absinfo {
> #define KEY_DISPLAY_OFF 245 /* display device to off state */
>
> #define KEY_WIMAX 246
> +#define KEY_FM 247
>
> /* Range 248 - 255 is reserved for special needs of AT keyboard driver */
>
> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> index 3392c59..03f5598 100644
> --- a/include/linux/rfkill.h
> +++ b/include/linux/rfkill.h
> @@ -45,6 +45,7 @@ enum rfkill_type {
> RFKILL_TYPE_WIMAX,
> RFKILL_TYPE_WWAN,
> RFKILL_TYPE_GPS,
> + RFKILL_TYPE_FM,
> NUM_RFKILL_TYPES,
> };
>
> diff --git a/net/rfkill/core.c b/net/rfkill/core.c
> index ba2efb9..b8ac206 100644
> --- a/net/rfkill/core.c
> +++ b/net/rfkill/core.c
> @@ -592,6 +592,8 @@ static const char *rfkill_get_type_str(enum
> rfkill_type type)
> return "wwan";
> case RFKILL_TYPE_GPS:
> return "gps";
> + case RRFKILL_TYPE_FM:
> + return "fm";
> default:
> BUG();
> }
> diff --git a/net/rfkill/input.c b/net/rfkill/input.c
> index a7295ad..f51b16d 100644
> --- a/net/rfkill/input.c
> +++ b/net/rfkill/input.c
> @@ -212,6 +212,9 @@ static void rfkill_event(struct input_handle
> *handle, unsigned int type,
> case KEY_WIMAX:
> rfkill_schedule_toggle(RFKILL_TYPE_WIMAX);
> break;
> + case KEY_FM:
> + rfkill_schedule_toggle(RFKILL_TYPE_FM);
> + break;
> }
> } else if (type == EV_SW && code == SW_RFKILL_ALL)
> rfkill_schedule_evsw_rfkillall(data);
> @@ -290,6 +293,12 @@ static const struct input_device_id rfkill_ids[] = {
> .keybit = { [BIT_WORD(KEY_UWB)] = BIT_MASK(KEY_UWB) },
> },
> {
> + .flags = INPUT_DEVICE_ID_MATCH_EVBIT |
> + INPUT_DEVICE_ID_MATCH_KEYBIT,
> + .evbit = { BIT_MASK(EV_KEY) },
> + .keybit = { [BIT_WORD(KEY_FM)] = BIT_MASK(KEY_UWB) },
Surely both instances of KEY_UWB should be changed.
> + },
> + {
> .flags = INPUT_DEVICE_ID_MATCH_EVBIT | INPUT_DEVICE_ID_MATCH_KEYBIT,
> .evbit = { BIT_MASK(EV_KEY) },
> .keybit = { [BIT_WORD(KEY_WIMAX)] = BIT_MASK(KEY_WIMAX) },
> --
> 1.5.4.3
>
> Regards,
> Ram.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Julian Calaby
Email: julian.calaby@gmail.com
.Plan: http://sites.google.com/site/juliancalaby/
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [patch 0/1] Adding radio type FM
2009-11-13 3:29 ` Julian Calaby
@ 2009-11-13 3:41 ` Marcel Holtmann
2009-11-13 3:45 ` Julian Calaby
0 siblings, 1 reply; 21+ messages in thread
From: Marcel Holtmann @ 2009-11-13 3:41 UTC (permalink / raw)
To: Julian Calaby
Cc: Janakiram Sistla, John W. Linville, linux-wireless, linux-kernel
Hi Julian,
please stop CCing majordomo@vger.kernel.org since that one is not a
mailing list.
> <janakiram.sistla@gmail.com> wrote:
> > Resending with added comments from John.
> > From 1b1493392faeb6702ff364447b135e481930b397 Mon Sep 17 00:00:00 2001
> > From: Janakiram Sistla <janakiram.sistla@gmail.com>
> > Date: Fri, 13 Nov 2009 08:16:26 +0530
> > Subject: [PATCH 1/1] Adding radio type FM
> >
> > Adding radio type FM in RFKILL_TYPE_.FM also belongs to
> > same class of with both TX/RX capability.
> > Also Added input type for the above same.
> >
> > Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
> > ---
> > include/linux/input.h | 1 +
> > include/linux/rfkill.h | 1 +
> > net/rfkill/core.c | 2 ++
> > net/rfkill/input.c | 9 +++++++++
> > 4 files changed, 13 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/linux/input.h b/include/linux/input.h
> > index 0ccfc30..f03ae90 100644
> > --- a/include/linux/input.h
> > +++ b/include/linux/input.h
> > @@ -376,6 +376,7 @@ struct input_absinfo {
> > #define KEY_DISPLAY_OFF 245 /* display device to off state */
> >
> > #define KEY_WIMAX 246
> > +#define KEY_FM 247
> >
> > /* Range 248 - 255 is reserved for special needs of AT keyboard driver */
> >
> > diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> > index 3392c59..03f5598 100644
> > --- a/include/linux/rfkill.h
> > +++ b/include/linux/rfkill.h
> > @@ -45,6 +45,7 @@ enum rfkill_type {
> > RFKILL_TYPE_WIMAX,
> > RFKILL_TYPE_WWAN,
> > RFKILL_TYPE_GPS,
> > + RFKILL_TYPE_FM,
> > NUM_RFKILL_TYPES,
> > };
> >
> > diff --git a/net/rfkill/core.c b/net/rfkill/core.c
> > index ba2efb9..b8ac206 100644
> > --- a/net/rfkill/core.c
> > +++ b/net/rfkill/core.c
> > @@ -592,6 +592,8 @@ static const char *rfkill_get_type_str(enum
> > rfkill_type type)
> > return "wwan";
> > case RFKILL_TYPE_GPS:
> > return "gps";
> > + case RRFKILL_TYPE_FM:
> > + return "fm";
> > default:
> > BUG();
> > }
> > diff --git a/net/rfkill/input.c b/net/rfkill/input.c
> > index a7295ad..f51b16d 100644
> > --- a/net/rfkill/input.c
> > +++ b/net/rfkill/input.c
> > @@ -212,6 +212,9 @@ static void rfkill_event(struct input_handle
> > *handle, unsigned int type,
> > case KEY_WIMAX:
> > rfkill_schedule_toggle(RFKILL_TYPE_WIMAX);
> > break;
> > + case KEY_FM:
> > + rfkill_schedule_toggle(RFKILL_TYPE_FM);
> > + break;
> > }
> > } else if (type == EV_SW && code == SW_RFKILL_ALL)
> > rfkill_schedule_evsw_rfkillall(data);
> > @@ -290,6 +293,12 @@ static const struct input_device_id rfkill_ids[] = {
> > .keybit = { [BIT_WORD(KEY_UWB)] = BIT_MASK(KEY_UWB) },
> > },
> > {
> > + .flags = INPUT_DEVICE_ID_MATCH_EVBIT |
> > + INPUT_DEVICE_ID_MATCH_KEYBIT,
> > + .evbit = { BIT_MASK(EV_KEY) },
> > + .keybit = { [BIT_WORD(KEY_FM)] = BIT_MASK(KEY_UWB) },
>
> Surely both instances of KEY_UWB should be changed.
which makes it even more clearly that this code path has never been
tested. So lets leave this KEY_FM business out and just submit the
RFKILL additions.
You don't need to emulate a key event to use RFKILL anyway. The new
RFKILL subsystem supports /dev/rfkill and there is the rfkill userspace
utility. Which you wanna send a patch to extend it with FM support.
Regards
Marcel
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [patch 0/1] Adding radio type FM
2009-11-13 3:41 ` Marcel Holtmann
@ 2009-11-13 3:45 ` Julian Calaby
2009-11-13 5:19 ` Janakiram Sistla
0 siblings, 1 reply; 21+ messages in thread
From: Julian Calaby @ 2009-11-13 3:45 UTC (permalink / raw)
To: Marcel Holtmann
Cc: Janakiram Sistla, John W. Linville, linux-wireless, linux-kernel
On Fri, Nov 13, 2009 at 14:41, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Julian,
>
> please stop CCing majordomo@vger.kernel.org since that one is not a
> mailing list.
I never intended to: I didn't check the CCs when I hit reply-all.
I realised it had been CC'd right after it sent me an email telling me
(in a rather verbose fashion) that I was an idiot.
Thanks,
--
Julian Calaby
Email: julian.calaby@gmail.com
.Plan: http://sites.google.com/site/juliancalaby/
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [patch 0/1] Adding radio type FM
2009-11-13 3:45 ` Julian Calaby
@ 2009-11-13 5:19 ` Janakiram Sistla
2009-11-13 5:30 ` Marcel Holtmann
0 siblings, 1 reply; 21+ messages in thread
From: Janakiram Sistla @ 2009-11-13 5:19 UTC (permalink / raw)
To: Julian Calaby
Cc: Marcel Holtmann, John W. Linville, linux-wireless, linux-kernel
Hi Marcel,
Thankyou for all the comments on the patch.Yes if you see the toshiba
Laptop series which have an FM key that enables FM.If still People say
that we cannot take KEY_FM yes we will go ahead and will resubmit a
patch with only RFKILL for FM
Regards,
Ram.
On Fri, Nov 13, 2009 at 9:15 AM, Julian Calaby <julian.calaby@gmail.com> wrote:
> On Fri, Nov 13, 2009 at 14:41, Marcel Holtmann <marcel@holtmann.org> wrote:
>> Hi Julian,
>>
>> please stop CCing majordomo@vger.kernel.org since that one is not a
>> mailing list.
>
> I never intended to: I didn't check the CCs when I hit reply-all.
>
> I realised it had been CC'd right after it sent me an email telling me
> (in a rather verbose fashion) that I was an idiot.
>
> Thanks,
>
> --
>
> Julian Calaby
>
> Email: julian.calaby@gmail.com
> .Plan: http://sites.google.com/site/juliancalaby/
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [patch 0/1] Adding radio type FM
2009-11-13 5:19 ` Janakiram Sistla
@ 2009-11-13 5:30 ` Marcel Holtmann
0 siblings, 0 replies; 21+ messages in thread
From: Marcel Holtmann @ 2009-11-13 5:30 UTC (permalink / raw)
To: Janakiram Sistla
Cc: Julian Calaby, John W. Linville, linux-wireless, linux-kernel
Hi Janakiram,
> Thankyou for all the comments on the patch.Yes if you see the toshiba
> Laptop series which have an FM key that enables FM.If still People say
> that we cannot take KEY_FM yes we will go ahead and will resubmit a
> patch with only RFKILL for FM
how is that key mapped in reality? Or is that just a KEY_RFKILL toggle
sort of key.
Submit the patch without the input modifications since that can be acked
right away. And don't forget to send a patch for rfkill utility that
adds FM support.
Regards
Marcel
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [patch 0/1] Adding radio type FM
2009-11-13 3:09 [patch 0/1] Adding radio type FM Janakiram Sistla
2009-11-13 3:09 ` John W. Linville
@ 2009-11-13 3:22 ` Marcel Holtmann
2009-11-13 5:32 ` Janakiram Sistla
2009-11-14 13:19 ` Janakiram Sistla
1 sibling, 2 replies; 21+ messages in thread
From: Marcel Holtmann @ 2009-11-13 3:22 UTC (permalink / raw)
To: Janakiram Sistla; +Cc: linux-wireless, linux-kernel
Hi Janakiram,
> From 1b1493392faeb6702ff364447b135e481930b397 Mon Sep 17 00:00:00 2001
> From: Janakiram Sistla <janakiram.sistla@gmail.com>
> Date: Fri, 13 Nov 2009 08:16:26 +0530
> Subject: [PATCH 1/1] Adding radio type FM
>
> Adding radio type FM in RFKILL_TYPE_.FM also belongs to
> same class of with both TX/RX capability.
> Also Added input type for the above same.
>
> Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
> ---
> include/linux/input.h | 1 +
> include/linux/rfkill.h | 1 +
> net/rfkill/core.c | 2 ++
> net/rfkill/input.c | 9 +++++++++
> 4 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/input.h b/include/linux/input.h
> index 0ccfc30..f03ae90 100644
> --- a/include/linux/input.h
> +++ b/include/linux/input.h
> @@ -376,6 +376,7 @@ struct input_absinfo {
> #define KEY_DISPLAY_OFF 245 /* display device to off state */
>
> #define KEY_WIMAX 246
> +#define KEY_FM 247
>
> /* Range 248 - 255 is reserved for special needs of AT keyboard driver */
>
> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> index 3392c59..03f5598 100644
> --- a/include/linux/rfkill.h
> +++ b/include/linux/rfkill.h
> @@ -45,6 +45,7 @@ enum rfkill_type {
> RFKILL_TYPE_WIMAX,
> RFKILL_TYPE_WWAN,
> RFKILL_TYPE_GPS,
> + RFKILL_TYPE_FM,
> NUM_RFKILL_TYPES,
> };
>
> diff --git a/net/rfkill/core.c b/net/rfkill/core.c
> index ba2efb9..b8ac206 100644
> --- a/net/rfkill/core.c
> +++ b/net/rfkill/core.c
> @@ -592,6 +592,8 @@ static const char *rfkill_get_type_str(enum
> rfkill_type type)
> return "wwan";
> case RFKILL_TYPE_GPS:
> return "gps";
> + case RRFKILL_TYPE_FM:
> + return "fm";
> default:
> BUG();
> }
this part is fine with me.
> diff --git a/net/rfkill/input.c b/net/rfkill/input.c
> index a7295ad..f51b16d 100644
> --- a/net/rfkill/input.c
> +++ b/net/rfkill/input.c
> @@ -212,6 +212,9 @@ static void rfkill_event(struct input_handle
> *handle, unsigned int type,
> case KEY_WIMAX:
> rfkill_schedule_toggle(RFKILL_TYPE_WIMAX);
> break;
> + case KEY_FM:
> + rfkill_schedule_toggle(RFKILL_TYPE_FM);
> + break;
> }
> } else if (type == EV_SW && code == SW_RFKILL_ALL)
> rfkill_schedule_evsw_rfkillall(data);
> @@ -290,6 +293,12 @@ static const struct input_device_id rfkill_ids[] = {
> .keybit = { [BIT_WORD(KEY_UWB)] = BIT_MASK(KEY_UWB) },
> },
> {
> + .flags = INPUT_DEVICE_ID_MATCH_EVBIT |
> + INPUT_DEVICE_ID_MATCH_KEYBIT,
> + .evbit = { BIT_MASK(EV_KEY) },
> + .keybit = { [BIT_WORD(KEY_UWB)] = BIT_MASK(KEY_UWB) },
> + },
> + {
> .flags = INPUT_DEVICE_ID_MATCH_EVBIT | INPUT_DEVICE_ID_MATCH_KEYBIT,
> .evbit = { BIT_MASK(EV_KEY) },
> .keybit = { [BIT_WORD(KEY_WIMAX)] = BIT_MASK(KEY_WIMAX) },
So besides the pointed of the copy-and-paste mistake, I don't think we
should be doing this. Unless you point me to hardware that actually has
a physical RFKILL button for FM. We also didn't add key define for GPS
since there is no hardware that has this.
If you think you need this for some weird handling then go one step back
and read the re-written RFKILL subsystem design.
Regards
Marcel
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [patch 0/1] Adding radio type FM
2009-11-13 3:22 ` Marcel Holtmann
@ 2009-11-13 5:32 ` Janakiram Sistla
2009-11-13 18:19 ` Janakiram Sistla
2009-11-14 13:19 ` Janakiram Sistla
1 sibling, 1 reply; 21+ messages in thread
From: Janakiram Sistla @ 2009-11-13 5:32 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linux-wireless, linux-kernel
HI Marcel,
Yes as pointed out i am pointing to Toshiba Satellite A305
notebook.This has an FM key which enables FM.
Regards,
Ram.
On 11/13/09, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Janakiram,
>
> > From 1b1493392faeb6702ff364447b135e481930b397 Mon Sep 17 00:00:00 2001
> > From: Janakiram Sistla <janakiram.sistla@gmail.com>
> > Date: Fri, 13 Nov 2009 08:16:26 +0530
> > Subject: [PATCH 1/1] Adding radio type FM
> >
> > Adding radio type FM in RFKILL_TYPE_.FM also belongs to
> > same class of with both TX/RX capability.
> > Also Added input type for the above same.
> >
> > Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
> > ---
> > include/linux/input.h | 1 +
> > include/linux/rfkill.h | 1 +
> > net/rfkill/core.c | 2 ++
> > net/rfkill/input.c | 9 +++++++++
> > 4 files changed, 13 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/linux/input.h b/include/linux/input.h
> > index 0ccfc30..f03ae90 100644
> > --- a/include/linux/input.h
> > +++ b/include/linux/input.h
> > @@ -376,6 +376,7 @@ struct input_absinfo {
> > #define KEY_DISPLAY_OFF 245 /* display device to off state */
> >
> > #define KEY_WIMAX 246
> > +#define KEY_FM 247
> >
> > /* Range 248 - 255 is reserved for special needs of AT keyboard driver */
> >
> > diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> > index 3392c59..03f5598 100644
> > --- a/include/linux/rfkill.h
> > +++ b/include/linux/rfkill.h
> > @@ -45,6 +45,7 @@ enum rfkill_type {
> > RFKILL_TYPE_WIMAX,
> > RFKILL_TYPE_WWAN,
> > RFKILL_TYPE_GPS,
> > + RFKILL_TYPE_FM,
> > NUM_RFKILL_TYPES,
> > };
> >
> > diff --git a/net/rfkill/core.c b/net/rfkill/core.c
> > index ba2efb9..b8ac206 100644
> > --- a/net/rfkill/core.c
> > +++ b/net/rfkill/core.c
> > @@ -592,6 +592,8 @@ static const char *rfkill_get_type_str(enum
> > rfkill_type type)
> > return "wwan";
> > case RFKILL_TYPE_GPS:
> > return "gps";
> > + case RRFKILL_TYPE_FM:
> > + return "fm";
> > default:
> > BUG();
> > }
>
> this part is fine with me.
>
> > diff --git a/net/rfkill/input.c b/net/rfkill/input.c
> > index a7295ad..f51b16d 100644
> > --- a/net/rfkill/input.c
> > +++ b/net/rfkill/input.c
> > @@ -212,6 +212,9 @@ static void rfkill_event(struct input_handle
> > *handle, unsigned int type,
> > case KEY_WIMAX:
> > rfkill_schedule_toggle(RFKILL_TYPE_WIMAX);
> > break;
> > + case KEY_FM:
> > + rfkill_schedule_toggle(RFKILL_TYPE_FM);
> > + break;
> > }
> > } else if (type == EV_SW && code == SW_RFKILL_ALL)
> > rfkill_schedule_evsw_rfkillall(data);
> > @@ -290,6 +293,12 @@ static const struct input_device_id rfkill_ids[] = {
> > .keybit = { [BIT_WORD(KEY_UWB)] = BIT_MASK(KEY_UWB) },
> > },
> > {
> > + .flags = INPUT_DEVICE_ID_MATCH_EVBIT |
> > + INPUT_DEVICE_ID_MATCH_KEYBIT,
> > + .evbit = { BIT_MASK(EV_KEY) },
> > + .keybit = { [BIT_WORD(KEY_UWB)] = BIT_MASK(KEY_UWB) },
> > + },
> > + {
> > .flags = INPUT_DEVICE_ID_MATCH_EVBIT | INPUT_DEVICE_ID_MATCH_KEYBIT,
> > .evbit = { BIT_MASK(EV_KEY) },
> > .keybit = { [BIT_WORD(KEY_WIMAX)] = BIT_MASK(KEY_WIMAX) },
>
> So besides the pointed of the copy-and-paste mistake, I don't think we
> should be doing this. Unless you point me to hardware that actually has
> a physical RFKILL button for FM. We also didn't add key define for GPS
> since there is no hardware that has this.
>
> If you think you need this for some weird handling then go one step back
> and read the re-written RFKILL subsystem design.
>
> Regards
>
> Marcel
>
>
>
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [patch 0/1] Adding radio type FM
2009-11-13 5:32 ` Janakiram Sistla
@ 2009-11-13 18:19 ` Janakiram Sistla
0 siblings, 0 replies; 21+ messages in thread
From: Janakiram Sistla @ 2009-11-13 18:19 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linux-wireless, linux-kernel
Hi Marcel,
Let me know if this patch can go ahead...........and i can go ahead
with this in rfkill utility.......
Regards,
Ram.
On Fri, Nov 13, 2009 at 11:02 AM, Janakiram Sistla
<janakiram.sistla@gmail.com> wrote:
> HI Marcel,
>
> Yes as pointed out i am pointing to Toshiba Satellite A305
> notebook.This has an FM key which enables FM.
>
> Regards,
> Ram.
> On 11/13/09, Marcel Holtmann <marcel@holtmann.org> wrote:
>> Hi Janakiram,
>>
>> > From 1b1493392faeb6702ff364447b135e481930b397 Mon Sep 17 00:00:00 2001
>> > From: Janakiram Sistla <janakiram.sistla@gmail.com>
>> > Date: Fri, 13 Nov 2009 08:16:26 +0530
>> > Subject: [PATCH 1/1] Adding radio type FM
>> >
>> > Adding radio type FM in RFKILL_TYPE_.FM also belongs to
>> > same class of with both TX/RX capability.
>> > Also Added input type for the above same.
>> >
>> > Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
>> > ---
>> > include/linux/input.h | 1 +
>> > include/linux/rfkill.h | 1 +
>> > net/rfkill/core.c | 2 ++
>> > net/rfkill/input.c | 9 +++++++++
>> > 4 files changed, 13 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/include/linux/input.h b/include/linux/input.h
>> > index 0ccfc30..f03ae90 100644
>> > --- a/include/linux/input.h
>> > +++ b/include/linux/input.h
>> > @@ -376,6 +376,7 @@ struct input_absinfo {
>> > #define KEY_DISPLAY_OFF 245 /* display device to off state */
>> >
>> > #define KEY_WIMAX 246
>> > +#define KEY_FM 247
>> >
>> > /* Range 248 - 255 is reserved for special needs of AT keyboard driver */
>> >
>> > diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
>> > index 3392c59..03f5598 100644
>> > --- a/include/linux/rfkill.h
>> > +++ b/include/linux/rfkill.h
>> > @@ -45,6 +45,7 @@ enum rfkill_type {
>> > RFKILL_TYPE_WIMAX,
>> > RFKILL_TYPE_WWAN,
>> > RFKILL_TYPE_GPS,
>> > + RFKILL_TYPE_FM,
>> > NUM_RFKILL_TYPES,
>> > };
>> >
>> > diff --git a/net/rfkill/core.c b/net/rfkill/core.c
>> > index ba2efb9..b8ac206 100644
>> > --- a/net/rfkill/core.c
>> > +++ b/net/rfkill/core.c
>> > @@ -592,6 +592,8 @@ static const char *rfkill_get_type_str(enum
>> > rfkill_type type)
>> > return "wwan";
>> > case RFKILL_TYPE_GPS:
>> > return "gps";
>> > + case RRFKILL_TYPE_FM:
>> > + return "fm";
>> > default:
>> > BUG();
>> > }
>>
>> this part is fine with me.
>>
>> > diff --git a/net/rfkill/input.c b/net/rfkill/input.c
>> > index a7295ad..f51b16d 100644
>> > --- a/net/rfkill/input.c
>> > +++ b/net/rfkill/input.c
>> > @@ -212,6 +212,9 @@ static void rfkill_event(struct input_handle
>> > *handle, unsigned int type,
>> > case KEY_WIMAX:
>> > rfkill_schedule_toggle(RFKILL_TYPE_WIMAX);
>> > break;
>> > + case KEY_FM:
>> > + rfkill_schedule_toggle(RFKILL_TYPE_FM);
>> > + break;
>> > }
>> > } else if (type == EV_SW && code == SW_RFKILL_ALL)
>> > rfkill_schedule_evsw_rfkillall(data);
>> > @@ -290,6 +293,12 @@ static const struct input_device_id rfkill_ids[] = {
>> > .keybit = { [BIT_WORD(KEY_UWB)] = BIT_MASK(KEY_UWB) },
>> > },
>> > {
>> > + .flags = INPUT_DEVICE_ID_MATCH_EVBIT |
>> > + INPUT_DEVICE_ID_MATCH_KEYBIT,
>> > + .evbit = { BIT_MASK(EV_KEY) },
>> > + .keybit = { [BIT_WORD(KEY_UWB)] = BIT_MASK(KEY_UWB) },
>> > + },
>> > + {
>> > .flags = INPUT_DEVICE_ID_MATCH_EVBIT | INPUT_DEVICE_ID_MATCH_KEYBIT,
>> > .evbit = { BIT_MASK(EV_KEY) },
>> > .keybit = { [BIT_WORD(KEY_WIMAX)] = BIT_MASK(KEY_WIMAX) },
>>
>> So besides the pointed of the copy-and-paste mistake, I don't think we
>> should be doing this. Unless you point me to hardware that actually has
>> a physical RFKILL button for FM. We also didn't add key define for GPS
>> since there is no hardware that has this.
>>
>> If you think you need this for some weird handling then go one step back
>> and read the re-written RFKILL subsystem design.
>>
>> Regards
>>
>> Marcel
>>
>>
>>
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [patch 0/1] Adding radio type FM
2009-11-13 3:22 ` Marcel Holtmann
2009-11-13 5:32 ` Janakiram Sistla
@ 2009-11-14 13:19 ` Janakiram Sistla
2009-11-14 16:34 ` Marcel Holtmann
1 sibling, 1 reply; 21+ messages in thread
From: Janakiram Sistla @ 2009-11-14 13:19 UTC (permalink / raw)
To: majordomo; +Cc: linux-wireless, linux-kernel, Marcel Holtmann
Resubmitting patch adding Marcels Comments
>From f72e4bdef7c423259f2f8f0615d024a25294ea8f Mon Sep 17 00:00:00 2001
From: Janakiram Sistla <janakiram.sistla@gmail.com>
Date: Sat, 14 Nov 2009 18:42:35 +0530
Subject: [PATCH 1/1] Adding radio type FM
Adding radio type FM in RFKILL_TYPE_.FM also belongs to
same class of with both TX/RX capability.
Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
---
include/linux/rfkill.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index 3392c59..03f5598 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -45,6 +45,7 @@ enum rfkill_type {
RFKILL_TYPE_WIMAX,
RFKILL_TYPE_WWAN,
RFKILL_TYPE_GPS,
+ RFKILL_TYPE_FM,
NUM_RFKILL_TYPES,
};
--
1.5.4.3
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [patch 0/1] Adding radio type FM
2009-11-14 13:19 ` Janakiram Sistla
@ 2009-11-14 16:34 ` Marcel Holtmann
2009-11-14 17:37 ` Janakiram Sistla
0 siblings, 1 reply; 21+ messages in thread
From: Marcel Holtmann @ 2009-11-14 16:34 UTC (permalink / raw)
To: Janakiram Sistla; +Cc: majordomo, linux-wireless, linux-kernel
Hi Janakiram,
> Resubmitting patch adding Marcels Comments
>
> From f72e4bdef7c423259f2f8f0615d024a25294ea8f Mon Sep 17 00:00:00 2001
> From: Janakiram Sistla <janakiram.sistla@gmail.com>
> Date: Sat, 14 Nov 2009 18:42:35 +0530
> Subject: [PATCH 1/1] Adding radio type FM
>
> Adding radio type FM in RFKILL_TYPE_.FM also belongs to
> same class of with both TX/RX capability.
>
> Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
> ---
> include/linux/rfkill.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> index 3392c59..03f5598 100644
> --- a/include/linux/rfkill.h
> +++ b/include/linux/rfkill.h
> @@ -45,6 +45,7 @@ enum rfkill_type {
> RFKILL_TYPE_WIMAX,
> RFKILL_TYPE_WWAN,
> RFKILL_TYPE_GPS,
> + RFKILL_TYPE_FM,
> NUM_RFKILL_TYPES,
> };
and what about rfkill_get_type_str() changes?
Regards
Marcel
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [patch 0/1] Adding radio type FM
2009-11-14 16:34 ` Marcel Holtmann
@ 2009-11-14 17:37 ` Janakiram Sistla
2009-11-14 18:05 ` Marcel Holtmann
0 siblings, 1 reply; 21+ messages in thread
From: Janakiram Sistla @ 2009-11-14 17:37 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linux-wireless, linux-kernel
Hi Marcel,
I thought i would see the change first in include/linux/rfkill.h
getting accepted and then i can add the change in core.c also.
Let me know if i can push both in the same patch.
Regards,
Ram.
On Sat, Nov 14, 2009 at 10:04 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Janakiram,
>
>> Resubmitting patch adding Marcels Comments
>>
>> From f72e4bdef7c423259f2f8f0615d024a25294ea8f Mon Sep 17 00:00:00 2001
>> From: Janakiram Sistla <janakiram.sistla@gmail.com>
>> Date: Sat, 14 Nov 2009 18:42:35 +0530
>> Subject: [PATCH 1/1] Adding radio type FM
>>
>> Adding radio type FM in RFKILL_TYPE_.FM also belongs to
>> same class of with both TX/RX capability.
>>
>> Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
>> ---
>> include/linux/rfkill.h | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
>> index 3392c59..03f5598 100644
>> --- a/include/linux/rfkill.h
>> +++ b/include/linux/rfkill.h
>> @@ -45,6 +45,7 @@ enum rfkill_type {
>> RFKILL_TYPE_WIMAX,
>> RFKILL_TYPE_WWAN,
>> RFKILL_TYPE_GPS,
>> + RFKILL_TYPE_FM,
>> NUM_RFKILL_TYPES,
>> };
>
> and what about rfkill_get_type_str() changes?
>
> Regards
>
> Marcel
>
>
>
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: [patch 0/1] Adding radio type FM
2009-11-14 17:37 ` Janakiram Sistla
@ 2009-11-14 18:05 ` Marcel Holtmann
2009-11-16 2:36 ` [PATCH 1/1] " Janakiram Sistla
0 siblings, 1 reply; 21+ messages in thread
From: Marcel Holtmann @ 2009-11-14 18:05 UTC (permalink / raw)
To: Janakiram Sistla; +Cc: linux-wireless, linux-kernel
Hi Janakiram,
> I thought i would see the change first in include/linux/rfkill.h
> getting accepted and then i can add the change in core.c also.
>
> Let me know if i can push both in the same patch.
I said that you can add RFKILL_TYPE_FM to the RFKILL subsystem, but the
input changes might not be the right ones. Since eventually the
in-kernel input support will be removed.
And I did ask if the FM button you see is a generic RFKILL toggle or a
FM specific button. Especially since you had a copy-and-paste mistake in
your patches, that code path clearly was never tested by you.
Regards
Marcel
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 1/1] Adding radio type FM
2009-11-14 18:05 ` Marcel Holtmann
@ 2009-11-16 2:36 ` Janakiram Sistla
2009-11-16 2:43 ` Marcel Holtmann
0 siblings, 1 reply; 21+ messages in thread
From: Janakiram Sistla @ 2009-11-16 2:36 UTC (permalink / raw)
To: majordomo; +Cc: linux-wireless, linux-kernel, Marcel Holtmann
Adding changes RFKILL type FM and for RFKILL for FM in core
>From 4bf0ae6c90de9a766914abeb5ab5e5428089b648 Mon Sep 17 00:00:00 2001
From: Janakiram Sistla <janakiram.sistla@gmail.com>
Date: Mon, 16 Nov 2009 07:58:09 +0530
Subject: [PATCH 1/1] Adding radio type FM
Adding radio type FM in RFKILL_TYPE_.FM belongs to
same class of with both TX/RX capability.
Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
---
include/linux/rfkill.h | 1 +
net/rfkill/core.c | 2 ++
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index 3392c59..03f5598 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -45,6 +45,7 @@ enum rfkill_type {
RFKILL_TYPE_WIMAX,
RFKILL_TYPE_WWAN,
RFKILL_TYPE_GPS,
+ RFKILL_TYPE_FM,
NUM_RFKILL_TYPES,
};
diff --git a/net/rfkill/core.c b/net/rfkill/core.c
index ba2efb9..61b716e 100644
--- a/net/rfkill/core.c
+++ b/net/rfkill/core.c
@@ -590,6 +590,8 @@ static const char *rfkill_get_type_str(enum
rfkill_type type)
return "wimax";
case RFKILL_TYPE_WWAN:
return "wwan";
+ case RFKILL_TYPE_FM:
+ return "fm";
case RFKILL_TYPE_GPS:
return "gps";
default:
--
1.5.4.3
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH 1/1] Adding radio type FM
2009-11-16 2:36 ` [PATCH 1/1] " Janakiram Sistla
@ 2009-11-16 2:43 ` Marcel Holtmann
2009-11-16 4:25 ` Janakiram Sistla
0 siblings, 1 reply; 21+ messages in thread
From: Marcel Holtmann @ 2009-11-16 2:43 UTC (permalink / raw)
To: Janakiram Sistla; +Cc: linux-wireless, linux-kernel
Hi Janakiram,
so first of all, please stop sending emails to majordomo. That is not a
real person.
> Adding changes RFKILL type FM and for RFKILL for FM in core
>
> From 4bf0ae6c90de9a766914abeb5ab5e5428089b648 Mon Sep 17 00:00:00 2001
> From: Janakiram Sistla <janakiram.sistla@gmail.com>
> Date: Mon, 16 Nov 2009 07:58:09 +0530
> Subject: [PATCH 1/1] Adding radio type FM
>
> Adding radio type FM in RFKILL_TYPE_.FM belongs to
> same class of with both TX/RX capability.
>
> Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
the patch itself is fine, but can we get at least one with a proper
commit message. And if you mailer is broken, then either fix it or use
git send-email.
Regards
Marcel
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 1/1] Adding radio type FM
2009-11-16 2:43 ` Marcel Holtmann
@ 2009-11-16 4:25 ` Janakiram Sistla
0 siblings, 0 replies; 21+ messages in thread
From: Janakiram Sistla @ 2009-11-16 4:25 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linux-wireless, linux-kernel
Hi Marcel,
I am sorry about this.There is a problem with my git send-email.so i
had to use the mailer.I will surely take complete precaution that it
will not repeat further.
Regards,
Ram.
On 11/16/09, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Janakiram,
>
> so first of all, please stop sending emails to majordomo. That is not a
> real person.
>
> > Adding changes RFKILL type FM and for RFKILL for FM in core
> >
> > From 4bf0ae6c90de9a766914abeb5ab5e5428089b648 Mon Sep 17 00:00:00 2001
> > From: Janakiram Sistla <janakiram.sistla@gmail.com>
> > Date: Mon, 16 Nov 2009 07:58:09 +0530
> > Subject: [PATCH 1/1] Adding radio type FM
> >
> > Adding radio type FM in RFKILL_TYPE_.FM belongs to
> > same class of with both TX/RX capability.
> >
> > Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
>
> the patch itself is fine, but can we get at least one with a proper
> commit message. And if you mailer is broken, then either fix it or use
> git send-email.
>
> Regards
>
> Marcel
>
>
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 1/1] Adding radio type FM
@ 2009-11-17 17:48 Janakiram Sistla
2009-11-17 18:31 ` John W. Linville
0 siblings, 1 reply; 21+ messages in thread
From: Janakiram Sistla @ 2009-11-17 17:48 UTC (permalink / raw)
To: marcel; +Cc: linux-wireless, Janakiram Sistla
From: Janakiram Sistla <janakiram.sistla@gmail.com>
Adding radio type FM in RFKILL_TYPE_.FM belongs to
same class of with both TX/RX capability.
Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
---
include/linux/rfkill.h | 1 +
net/rfkill/core.c | 2 ++
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index 3392c59..03f5598 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -45,6 +45,7 @@ enum rfkill_type {
RFKILL_TYPE_WIMAX,
RFKILL_TYPE_WWAN,
RFKILL_TYPE_GPS,
+ RFKILL_TYPE_FM,
NUM_RFKILL_TYPES,
};
diff --git a/net/rfkill/core.c b/net/rfkill/core.c
index ba2efb9..61b716e 100644
--- a/net/rfkill/core.c
+++ b/net/rfkill/core.c
@@ -590,6 +590,8 @@ static const char *rfkill_get_type_str(enum rfkill_type type)
return "wimax";
case RFKILL_TYPE_WWAN:
return "wwan";
+ case RFKILL_TYPE_FM:
+ return "fm";
case RFKILL_TYPE_GPS:
return "gps";
default:
--
1.5.4.3
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH 1/1] Adding radio type FM
2009-11-17 17:48 Janakiram Sistla
@ 2009-11-17 18:31 ` John W. Linville
2009-11-17 18:47 ` John W. Linville
0 siblings, 1 reply; 21+ messages in thread
From: John W. Linville @ 2009-11-17 18:31 UTC (permalink / raw)
To: Janakiram Sistla; +Cc: marcel, linux-wireless
On Tue, Nov 17, 2009 at 11:18:33PM +0530, Janakiram Sistla wrote:
> From: Janakiram Sistla <janakiram.sistla@gmail.com>
>
> Adding radio type FM in RFKILL_TYPE_.FM belongs to
> same class of with both TX/RX capability.
>
> Signed-off-by: Janakiram Sistla <janakiram.sistla@gmail.com>
> ---
> include/linux/rfkill.h | 1 +
> net/rfkill/core.c | 2 ++
> 2 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> index 3392c59..03f5598 100644
> --- a/include/linux/rfkill.h
> +++ b/include/linux/rfkill.h
> @@ -45,6 +45,7 @@ enum rfkill_type {
> RFKILL_TYPE_WIMAX,
> RFKILL_TYPE_WWAN,
> RFKILL_TYPE_GPS,
> + RFKILL_TYPE_FM,
> NUM_RFKILL_TYPES,
> };
>
> diff --git a/net/rfkill/core.c b/net/rfkill/core.c
> index ba2efb9..61b716e 100644
> --- a/net/rfkill/core.c
> +++ b/net/rfkill/core.c
> @@ -590,6 +590,8 @@ static const char *rfkill_get_type_str(enum rfkill_type type)
> return "wimax";
> case RFKILL_TYPE_WWAN:
> return "wwan";
> + case RFKILL_TYPE_FM:
> + return "fm";
> case RFKILL_TYPE_GPS:
> return "gps";
> default:
My personal taste would dictate that you add the case statement
in the same place that you added the enum. Depending on which
order you choose, you may need to change the BUILD_BUG_ON on line
601 of net/rfkill/core.c. (Not sure how you managed to build w/
this patch...)
Also, when you add the enum you need to add the corresponding kerneldoc
(i.e. an @RFKILL_TYPE_FM comment) just above it.
Finally, please add "rfkill: " to the beginning of the subject line
when you resubmit your patch.
Thanks,
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2009-11-17 19:00 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-13 3:09 [patch 0/1] Adding radio type FM Janakiram Sistla
2009-11-13 3:09 ` John W. Linville
2009-11-13 3:25 ` Janakiram Sistla
2009-11-13 3:29 ` Julian Calaby
2009-11-13 3:41 ` Marcel Holtmann
2009-11-13 3:45 ` Julian Calaby
2009-11-13 5:19 ` Janakiram Sistla
2009-11-13 5:30 ` Marcel Holtmann
2009-11-13 3:22 ` Marcel Holtmann
2009-11-13 5:32 ` Janakiram Sistla
2009-11-13 18:19 ` Janakiram Sistla
2009-11-14 13:19 ` Janakiram Sistla
2009-11-14 16:34 ` Marcel Holtmann
2009-11-14 17:37 ` Janakiram Sistla
2009-11-14 18:05 ` Marcel Holtmann
2009-11-16 2:36 ` [PATCH 1/1] " Janakiram Sistla
2009-11-16 2:43 ` Marcel Holtmann
2009-11-16 4:25 ` Janakiram Sistla
-- strict thread matches above, loose matches on Subject: below --
2009-11-17 17:48 Janakiram Sistla
2009-11-17 18:31 ` John W. Linville
2009-11-17 18:47 ` John W. Linville
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).