From: Johannes Berg <johannes@sipsolutions.net>
To: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rndis_wlan: handle NL80211_AUTHTYPE_AUTOMATIC
Date: Mon, 16 Nov 2009 11:22:04 +0100 [thread overview]
Message-ID: <1258366924.32159.11.camel@johannes.local> (raw)
In-Reply-To: <20091116095653.17419.49151.stgit@fate.lan>
[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]
On Mon, 2009-11-16 at 11:56 +0200, Jussi Kivilinna wrote:
> rndis_wlan didn't know about NL80211_AUTHTYPE_AUTOMATIC and simple
> setup with 'iwconfig wlan essid no-encrypt' would fail (ENOSUPP).
>
> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
> ---
>
> drivers/net/wireless/rndis_wlan.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rndis_wlan.c b/drivers/net/wireless/rndis_wlan.c
> index 54175b6..dfc61fd 100644
> --- a/drivers/net/wireless/rndis_wlan.c
> +++ b/drivers/net/wireless/rndis_wlan.c
> @@ -1070,7 +1070,8 @@ static int set_auth_mode(struct usbnet *usbdev, u32 wpa_version,
> auth_mode = NDIS_80211_AUTH_WPA_NONE;
> } else if (auth_type == NL80211_AUTHTYPE_SHARED_KEY)
> auth_mode = NDIS_80211_AUTH_SHARED;
> - else if (auth_type == NL80211_AUTHTYPE_OPEN_SYSTEM)
> + else if (auth_type == NL80211_AUTHTYPE_OPEN_SYSTEM ||
> + auth_type == NL80211_AUTHTYPE_AUTOMATIC)
> auth_mode = NDIS_80211_AUTH_OPEN;
Will that try open and shared though?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-11-16 10:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 9:56 [PATCH] rndis_wlan: handle NL80211_AUTHTYPE_AUTOMATIC Jussi Kivilinna
2009-11-16 10:22 ` Johannes Berg [this message]
2009-11-16 10:43 ` Jussi Kivilinna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258366924.32159.11.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=jussi.kivilinna@mbnet.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox