From: Johannes Berg <johannes@sipsolutions.net>
To: Rui Paulo <rpaulo@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: iw [PATCH] update to latest kernel changes (mesh)
Date: Mon, 16 Nov 2009 19:57:41 +0100 [thread overview]
Message-ID: <1258397861.32159.37.camel@johannes.local> (raw)
In-Reply-To: <1257771187-7894-2-git-send-email-rpaulo@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 582 bytes --]
On Mon, 2009-11-09 at 12:53 +0000, Rui Paulo wrote:
> mpath.c | 8 ++++----
> nl80211.h | 11 +++++++----
> - [NL80211_MPATH_INFO_DSN] = { .type = NLA_U32 },
> + [NL80211_MPATH_INFO_SN] = { .type = NLA_U32 },
I've kinda taken this, but it shouldn't have been necessary for
compiling.
Please don't ever again make API changes in nl80211.h without keeping a
backward compatible #define and noting so explicitly. I'd also
appreciate a patch adding the #define DSN SN just in case there are
other tools using nl80211.h and relying on it already.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2009-11-16 18:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 12:53 iw [PATCH] print a header before printing the list of mesh paths Rui Paulo
2009-11-09 12:53 ` iw [PATCH] update to latest kernel changes (mesh) Rui Paulo
2009-11-16 18:57 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258397861.32159.37.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=rpaulo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox